Move tomcat-jdbc into a javaagent folder #13567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
commented
Mar 21, 2025
| srcPath: instrumentation/opensearch/opensearch-java-2.0 | ||
| scope: | ||
| name: io.opentelemetry.opensearch-java-2.0 | ||
| target_versions: {} |
Member
Author
There was a problem hiding this comment.
this was just from me experimenting with writing new instrumentation and it got committed by mistake so i am removing it
laurit
approved these changes
Mar 21, 2025
steverao
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the documentation automation, I noticed that this
tomcat-jdbcinstrumentation wasn't being parsed correctly. When looking closer, it looks like it doesn't adhere to the normal pattern of having the code within ajavaagentdirectory, so I moved it around. If for some reason this was needed let me know and I can leave it alone and work around it in the documentation stuff.