Skip to content

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Apr 9, 2025

We don't use guava much so might as well only add the guava dependency to tests that need it. Most of the remaining guava usages are for ImmutableMap.of(). Multi element ImmutableMap.of()

  private static final ImmutableMap<String, String> testHashMap =
      ImmutableMap.of(
          "firstname", "John",
          "lastname", "Doe",
          "age", "53");

could be replaced with

  private static final Map<String, String> testHashMap =
      new HashMap<String, String>() {
        {
          put("firstname", "John");
          put("lastname", "Doe");
          put("age", "53");
        }
      };

if we want to get rid of these too.

@laurit laurit marked this pull request as ready for review April 9, 2025 12:28
@laurit laurit requested a review from a team as a code owner April 9, 2025 12:28
@trask trask merged commit d503937 into open-telemetry:main Apr 9, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants