Skip to content

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Apr 9, 2025

An alternative for #13678
#13393 had a small bug where it added a nested tasks element so the source version change didn't really apply

@laurit laurit requested a review from a team as a code owner April 9, 2025 16:12
@trask
Copy link
Member

trask commented Apr 9, 2025

how hard would it be to add a test?

@jeanbisutti
Copy link
Member

Perhaps

could be removed

@laurit
Copy link
Contributor Author

laurit commented Apr 9, 2025

Perhaps

could be removed

the tests don't work on earlier java versions, this ensures that the tests are only run with java 17+

@laurit
Copy link
Contributor Author

laurit commented Apr 9, 2025

how hard would it be to add a test?

I don't know how to test this as with this change we wish to influence the gradle metadata of the starter module so that it wouldn't contain any reference to java17. It is probably possible to achieve this by modifying metadata like in https://docs.gradle.org/current/userguide/component_metadata_rules.html but changing the java version seemed easier and we already used the same approach for the webmvc6 instrumentation.

@laurit laurit added this to the v2.15.0 milestone Apr 10, 2025
@trask trask merged commit 95cc300 into open-telemetry:main Apr 10, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants