Add Helidon Instrumentation

[SentryMan]

Adds helidon support

Resolves #11809 and helidon-io/helidon#10051

[tjquinno]

@SentryMan Your PR in Helidon that fixed the related problem is in release 4.2.3 which was released last week.

IIRC that was the blocker for this PR. Might you be able to try this one using 4.2.3 and see if it works?

[SentryMan]

@SentryMan Your PR in Helidon that fixed the related problem is in release 4.2.3 which was released last week.

There is no matchingPattern method on ServerRequest in this version

[tjquinno]

Ugh. You're right. I based my previous note on just a quick glance at the PR date vs. the release date of 4.2.3, but your bug fix was for an enhancement PR, and we are (almost) never including enhancements in dot-dot releases.

So 4.3 is the right release to use.

[tjquinno]

@SentryMan

There should be a 4.3.0-M1 not-yet-production milestone build available in maven central which contains the required change.

If you want to update this PR with that--while keeping this a draft because M1 is not production-ready--that might be useful. We are planning an M2 update soon with a production 4.3.0 coming.

[otelbot-java-instrumentation]

🔧 The result from spotlessApply was committed to the PR branch.

[SentryMan]

@laurit long time no see, how should I go about resolving this:

Cannot copy zip entry '/home/runner/.gradle/caches/modules-2/files-2.1/io.helidon.webserver/helidon-webserver/4.3.0/db68631c006aa1179e528d8045b180c5bbabeddd/helidon-webserver-4.3.0.jar!META-INF/LICENSE.txt' to 'META-INF/LICENSE.txt' because zip entry '/home/runner/work/opentelemetry-java-instrumentation/opentelemetry-java-instrumentation/javaagent-internal-logging-simple/build/libs/opentelemetry-javaagent-internal-logging-simple-2.21.0-alpha-SNAPSHOT-all.jar!META-INF/LICENSE.txt' has already been copied there.

[laurit]

@laurit long time no see, how should I go about resolving this:

Cannot copy zip entry '/home/runner/.gradle/caches/modules-2/files-2.1/io.helidon.webserver/helidon-webserver/4.3.0/db68631c006aa1179e528d8045b180c5bbabeddd/helidon-webserver-4.3.0.jar!META-INF/LICENSE.txt' to 'META-INF/LICENSE.txt' because zip entry '/home/runner/work/opentelemetry-java-instrumentation/opentelemetry-java-instrumentation/javaagent-internal-logging-simple/build/libs/opentelemetry-javaagent-internal-logging-simple-2.21.0-alpha-SNAPSHOT-all.jar!META-INF/LICENSE.txt' has already been copied there.

You could exclude the META-INF/LICENSE.txt in the failing relocateJavaagentLibsTmp task, but in your case that wouldn't be ideal. The real problem here is that you are attempting to package helidon-webserver-4.3.0.jar inside the agent jar which is probably not what you really want. Keep in mind that any implementation dependency of your instrumentation will be included with the agent. You should use library (our custom scope that means compileOnly + testImplementation) instead.

[SentryMan]

@laurit not sure I get it

[otelbot]

Thank you for your contribution @SentryMan! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.