make apache httpclient instrumentations indy-ready #13895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into indy-migration-3
SylvainJuge
commented
May 21, 2025
|
|
||
| @SuppressWarnings("unused") | ||
| public static class UriRequestAdvice { | ||
| public static class AdviceScope { |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] this AdviceScope class has been moved outside of the Advice classes as it allows to remove duplication, otherwise by default almost identical AdviceScope inner classes are created for each advice class.
JonasKunz
reviewed
May 22, 2025
...lemetry/javaagent/instrumentation/apachehttpclient/v2_0/ApacheHttpClientInstrumentation.java
Show resolved
Hide resolved
...lemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientInstrumentation.java
Outdated
Show resolved
Hide resolved
...lemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientInstrumentation.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-migration-3
…nstrumentation into indy-migration-3
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
JonasKunz
approved these changes
May 23, 2025
...lemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientInstrumentation.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-migration-3
laurit
reviewed
May 27, 2025
...lemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 27, 2025
...lemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031
two transformations applied:
ExperimentalInstrumentationModule.isIndyReady()to mark instrumentation indy-ready