Work around flaky java http client http/2 tests #13958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we disabled java http client http/2 tests on java 25 because they were too flaky and caused occasional build failures. While not as flaky as on java 25 the tests are still flaky on java 21+ (didn't see failures on earlier versions, but perhaps didn't look hard enough). I have a hypothesis that the failure stems from the server responding and reseting the stream when the client believes that it hasn't yet completely sent the request body. Which is weird, because the test harness sends an empty request body. With local testing the tests didn't fail any more with the added delay.