Skip to content

Remove netty workaround #13975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Remove netty workaround #13975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...mon/src/main/java/io/opentelemetry/instrumentation/testing/InstrumentationTestRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,6 @@
*/
public abstract class InstrumentationTestRunner {

static {
// In netty-4.1.121.Final unsafe usage is disabled by default on jdk24. This triggers using
// a different pooled buffer implementation which apparently breaks when initializing ssl. Here
// we switch to unpooled buffers to avoid that bug. We do this here because this code is
// executed early for both agent and library tests.
if (Double.parseDouble(System.getProperty("java.specification.version")) >= 24) {
System.setProperty("io.opentelemetry.testing.internal.io.netty.allocator.type", "unpooled");
}
}

private final TestInstrumenters testInstrumenters;
protected Map<String, MetricData> metrics = new HashMap<>();

Expand Down
Loading