Fix: Incorrect SNS Auto-Inst Unit Test Parameters in AWS SDK v2 #14000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to run the SNS unit test twice, each time with a different parameter: once with TopicArn, and once with TargetArn. However, the second argument was mistakenly nested as a sub-parameter of the first due to misaligned parentheses. As a result, the unit test only runs once—with TopicArn—and never runs with TargetArn. Tests Run: ./gradlew spotlessCheck ./gradlew clean assemble ./gradlew instrumentation:check ./gradlew :smoke-tests:test No regression issues found. Backward Compatibility: There is no risk of breaking existing functionality. This change only fixes one unit test without modifying the existing behavior of the auto-instrumentation library.
laurit
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to run the SNS unit test twice, each time with a different parameter: once with TopicArn, and once with TargetArn. However, the second argument was mistakenly nested as a sub-parameter of the first due to misaligned parentheses. As a result, the unit test only runs once—with TopicArn—and never runs with TargetArn.
Tests Run:
./gradlew spotlessCheck
./gradlew clean assemble
./gradlew instrumentation:check
./gradlew :smoke-tests:test
No regression issues found.
Backward Compatibility:
There is no risk of breaking existing functionality. This change only fixes one unit test without modifying the existing behavior of the auto-instrumentation library.