spring starter: add thread details instrumentation / configure logging span exporter #14117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
changed the title
|
@laurit please have a look 😄 |
laurit
reviewed
Jul 10, 2025
.../spring/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfiguration.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 10, 2025
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | ||
| * any time. | ||
| */ | ||
| @ConditionalOnEnabledInstrumentation(module = "common.thread-details", enabledByDefault = false) |
There was a problem hiding this comment.
agent enables this by default
There was a problem hiding this comment.
@trask please check if thread details should be disabled by default
There was a problem hiding this comment.
sorry, I forgot to raise it in semconv meeting, I've added it to next week's agenda so I won't forget
There was a problem hiding this comment.
@trask do you have an update?
There was a problem hiding this comment.
then it looks like we can leave it as is
laurit
reviewed
Jul 10, 2025
...rt/src/main/java/io/opentelemetry/instrumentation/logging/LoggingSpanExporterConfigurer.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 10, 2025
...ort/src/main/java/io/opentelemetry/instrumentation/thread/AddThreadDetailsSpanProcessor.java
Outdated
Show resolved
Hide resolved
zeitlinger
moved this from In Progress
to Awaiting Review
in Declarative Configuration: Java
|
🔧 The result from spotlessApply was committed to the PR branch. |
jaydeluca
reviewed
Jul 17, 2025
...entelemetry/instrumentation/internal/resources/ResourceProviderPropertiesCustomizerTest.java
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Jul 17, 2025
zeitlinger
commented
Aug 6, 2025
.../spring/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfiguration.java
Outdated
Show resolved
Hide resolved
…/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfiguration.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14087