Fix muzzle2 task failure in restlet-1.1 module #14159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jun 30, 2025
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
Thanks! I'm going to go ahead and merge this to fix the build.
I think my suggestion here is to remove the assertInverse and leave a comment there instead about why we can't use assertInverse
I don't think there's much risk of not using assertInverse in this particular case anyways, and any changes to muzzle to accommodate this usage pattern better may not be worth it.
wl2027
added a commit
to wl2027/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 30, 2025
assertInverse was removed because extraDependency is not available in later versions (e.g., 2.5.x),which causes exception during muzzle. open-telemetry#14159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix muzzle2 task failure in restlet-1.1 module
Meanwhile, I have two questions
The current
inverseOf()function completely copies all configurations from the original directive, includingextraDependency. However, some extraDependency entries may only exist within specific version ranges. Should we modify the logic so that implicitly generated fail tasks don't copy extraDependency settings, or add a version range restriction mechanism for extraDependency ?assertInverse.set(true)dynamically generates implicit fail directives, but the detailed configurations of these directives are not visible in error build logs. Should we print these implicitly generated fail task configurations during the build process to help developers better understand and troubleshoot issues?recurrence #14113