markdown link check -- remove github.token which is the default #14163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ah, great minds think alike, can we get in #14155 first? |
Contributor
Author
Oh yes totally, sorry I missed that. This will need a rework, but no biggie. |
Contributor
Author
|
Looks like the commandline (non-gha) lychee does like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/lycheeverse/lychee-action/blob/master/action.yml#L41 it seems like the argument was never spelled
--github-tokenand the default is justgithub.tokenanyway, and core omits it, so this should be fine.I'm running across the main java repos and making the markdown link check more consistent. This will align with contrib #1986.