Elasticsearch instrumentation metadata #14164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jul 10, 2025
| DbIncubatingAttributes.DbSystemIncubatingValues.ELASTICSEARCH), | ||
| equalTo(maybeStable(DB_OPERATION), "RefreshAction"))); | ||
|
|
||
| if (Boolean.getBoolean("testExperimental")) { |
Contributor
There was a problem hiding this comment.
if you added testExperimental only to tell whether tests are run with experimental flag then you could have used otel.instrumentation.elasticsearch.experimental-span-attributes too as it is also a system property. Keeping testExperimental is fine too.
laurit
reviewed
Jul 10, 2025
| DbIncubatingAttributes.DbSystemIncubatingValues.ELASTICSEARCH), | ||
| equalTo(maybeStable(DB_OPERATION), "ClusterHealthAction"))); | ||
|
|
||
| if (Boolean.getBoolean("testExperimental")) { |
Contributor
There was a problem hiding this comment.
another option would be to use something like equalTo(ELASTICSEARCH_ACTION, experimental("ClusterHealthAction")) where experimental() would return null when the experimental flag is not set. This could result in more compact assertions. Up to you to decide which way you like more.
Member
Author
There was a problem hiding this comment.
i like your approach better, thank you for the suggestion
laurit
approved these changes
Jul 14, 2025
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468
This PR covers all of the elasticsearch instrumentation