Convert distro build scripts from Groovy to Kotlin DSL #14176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR converts all distro example build scripts from Groovy (.gradle) to Kotlin DSL (.gradle.kts), removes the old Groovy counterparts, and introduces Kotlin-based convention plugins under buildSrc for formatting, shadowing, and instrumentation.
- Migrate root and subproject settings/build scripts to Kotlin DSL
- Remove legacy Groovy scripts and consolidate conventions in
buildSrc - Update dependency management and plugin declarations in Kotlin
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/distro/testing/agent-for-testing/build.gradle.kts | Kotlin DSL version of the agent-for-testing build |
| examples/distro/smoke-tests/build.gradle.kts | Kotlin DSL smoke tests build script |
| examples/distro/settings.gradle.kts | Kotlin DSL settings with pluginManagement |
| examples/distro/settings.gradle | Removed legacy Groovy settings |
| examples/distro/instrumentation/servlet-3/build.gradle.kts | Kotlin DSL servlet-3 instrumentation build |
| examples/distro/instrumentation/servlet-3/build.gradle | Removed Groovy servlet-3 script |
| examples/distro/instrumentation/build.gradle.kts | Kotlin DSL instrumentation aggregator script |
| examples/distro/instrumentation/build.gradle | Removed legacy Groovy instrumentation script |
| examples/distro/gradle/spotless.license.java | New license header file for Spotless |
| examples/distro/gradle/shadow.gradle | Removed legacy Groovy shadow conventions |
| examples/distro/gradle/instrumentation.gradle | Removed Groovy instrumentation conventions |
| examples/distro/dependencyManagement/build.gradle.kts | Kotlin DSL BOM/platform management |
| examples/distro/custom/build.gradle.kts | Kotlin DSL custom project build |
| examples/distro/buildSrc/src/main/kotlin/otel.spotless-conventions.gradle.kts | New Kotlin Spotless convention plugin |
| examples/distro/buildSrc/src/main/kotlin/otel.shadow-conventions.gradle.kts | New Kotlin ShadowJar convention plugin |
| examples/distro/buildSrc/src/main/kotlin/otel.java-conventions.gradle.kts | New Kotlin Java conventions plugin |
| examples/distro/buildSrc/src/main/kotlin/otel.instrumentation-conventions.gradle.kts | New Kotlin instrumentation conventions plugin |
| examples/distro/buildSrc/build.gradle.kts | buildSrc Kotlin DSL setup, Spotless & plugin deps |
| examples/distro/build.gradle.kts | Root Kotlin DSL build script |
| examples/distro/build.gradle | Removed Groovy root build script |
| examples/distro/bootstrap/build.gradle.kts | Kotlin DSL bootstrap project build stub |
| examples/distro/bootstrap/build.gradle | Removed Groovy bootstrap script |
| examples/distro/agent/build.gradle.kts | Kotlin DSL agent distro build |
| examples/distro/agent/build.gradle | Removed Groovy agent build script |
| } | ||
|
|
||
| val instrumentationTest = tasks.named("test") | ||
| val instrumentationDeps = dependencies |
There was a problem hiding this comment.
The instrumentationDeps variable is declared but never used. Consider removing it to reduce noise.
Suggested change
| val instrumentationDeps = dependencies |
| } | ||
|
|
||
| val otelVersion = "1.51.0" | ||
| val otelAlphaVersion = otelVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1") |
There was a problem hiding this comment.
The otelAlphaVersion variable is defined but not used anywhere in this script. You can remove it to simplify the code.
Suggested change
| val otelAlphaVersion = otelVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1") |
Comment on lines
+3
to
+6
| } | ||
|
|
||
| dependencies { | ||
| } No newline at end of file |
There was a problem hiding this comment.
[nitpick] This dependencies block is empty and can be removed to declutter the build script.
Suggested change
| } | |
| dependencies { | |
| } | |
| } |
| id("otel.java-conventions") | ||
| } | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
[nitpick] This dependencies block is empty and can be removed since there are no dependencies defined.
Contributor
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.