fix invalid jmx state metrics empty unit #14194
Merged
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
approved these changes
Jul 7, 2025
laurit
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14190
The addition of metrics unit conversion in JMX metrics (#13448) combined with using empty unit for
state metrics (#13796) introduced a regression in 2.17.0 as the
UnitConverter.getInstance(...)call throws an exception when called with an empty target unit, which is now always the case with state metrics.An exception was thrown which probably makes the JMX bean detection fail silently, this behavior was not explicitly tested so the simplest approach is probably to return
nullunit converter instance when we use it with an empty unit.