Skip to content

14218 - Add setObject to advice for java.sql.PreparedStatement #14219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laurit merged 6 commits into from
Jul 10, 2025
Merged

14218 - Add setObject to advice for java.sql.PreparedStatement #14219

laurit merged 6 commits into from
Jul 10, 2025

Conversation

@garethedwards-tass
Copy link
Contributor

@garethedwards-tass garethedwards-tass commented Jul 10, 2025 •
edited by trask
Loading

Resolves #14218

@garethedwards-tass garethedwards-tass requested a review from a team as a code owner July 10, 2025 04:28
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 10, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@laurit
Copy link
Contributor

laurit commented Jul 10, 2025

please also add a test

@garethedwards-tass
Copy link
Contributor Author

garethedwards-tass commented Jul 10, 2025

@laurit done

@garethedwards-tass
Copy link
Contributor Author

garethedwards-tass commented Jul 10, 2025 •
edited
Loading

Ok, I'm quite confused, perhaps the default ./gradlew test , isn't running my tests ? I thought this would be a simple change, help ?

Edit: ok, I got it failing by running ./gradlew :instrumentation:jdbc:javaagent:testCaptureParameters I should be able to work this out.

@otelbot-java-instrumentation
Copy link
Contributor

otelbot-java-instrumentation bot commented Jul 10, 2025

❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/16194382251.

@laurit
Copy link
Contributor

laurit commented Jul 10, 2025

@garethedwards-tass I pushed a change into your PR that will hopefully fix the failing test

@laurit laurit merged commit a236b69 into open-telemetry:main Jul 10, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add support for java.sql.PreparedStatement setObject in the PreparedStatementInstrumentation

3 participants

@garethedwards-tass @laurit @trask