add missing declarative config resource providers #14222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
from
f5600d0 to
6728f62
Compare
zeitlinger
moved this from In Progress
to Awaiting Review
in Declarative Configuration: Java
|
@laurit please have a look 😄 |
laurit
reviewed
Jul 16, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Outdated
Show resolved
Hide resolved
| return create(); | ||
| } | ||
|
|
||
| public Resource create() { |
There was a problem hiding this comment.
should this be part of the public api?
There was a problem hiding this comment.
JarResourceComponentProvider is in the internal package - so we need this to be public unless we do some tricks.
I actually don't mind it being in the public API - it signals that config properties are not needed.
There was a problem hiding this comment.
what if the detector decides later that it wants to look at config properties, but people are calling the method that doesn't pass in config properties?
...g/src/main/java/io/opentelemetry/javaagent/tooling/resources/ResourceCustomizerProvider.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 16, 2025
...g/src/main/java/io/opentelemetry/javaagent/tooling/resources/ResourceCustomizerProvider.java
Show resolved
Hide resolved
jaydeluca
reviewed
Jul 16, 2025
...a/io/opentelemetry/instrumentation/resources/internal/ManifestResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/instrumentation/resources/internal/JarResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/spring/resources/SpringResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Jul 17, 2025
|
@laurit can you check again? |
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
from
f283f17 to
e99c20a
Compare
|
@laurit can you check again? |
1 similar comment
|
@laurit can you check again? |
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
from
3616ed0 to
78f8138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14081