add missing declarative config resource providers #14222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
from
f5600d0 to
6728f62
Compare
zeitlinger
moved this from In Progress
to Awaiting Review
in Declarative Configuration: Java
|
@laurit please have a look 😄 |
laurit
reviewed
Jul 16, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/JarServiceNameDetector.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/io/opentelemetry/javaagent/tooling/resources/ResourceCustomizerProvider.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 16, 2025
...g/src/main/java/io/opentelemetry/javaagent/tooling/resources/ResourceCustomizerProvider.java
Show resolved
Hide resolved
jaydeluca
reviewed
Jul 16, 2025
...a/io/opentelemetry/instrumentation/resources/internal/ManifestResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/instrumentation/resources/internal/JarResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/spring/resources/SpringResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Jul 17, 2025
|
@laurit can you check again? |
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
from
f283f17 to
e99c20a
Compare
|
@laurit can you check again? |
1 similar comment
|
@laurit can you check again? |
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
2 times, most recently
from
78f8138 to
2a610ea
Compare
|
@trask can you check again? |
trask
reviewed
Aug 19, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 20, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/resources/AttributeResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/JarServiceNameDetector.java
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameDetector.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceVersionDetector.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/spring/resources/SpringResourceComponentProvider.java
Outdated
Show resolved
Hide resolved
|
@trask I've separated the "extraction" logic (which is re-usable) from the declarative and non-declarative provider interfaces, which should make the code easier to maintain (e.g. to delete the non-declarative classes) |
|
🔧 The result from spotlessApply was committed to the PR branch. |
zeitlinger
force-pushed
the
declarative-config-resource-providers
branch
from
66b0827 to
27bcee2
Compare
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
@trask can you check again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14081
To do: a full integration test for the java agent that verifies all resource attributes are set.