add missing configurations to the kafka documents #14225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jul 11, 2025
laurit
reviewed
Jul 11, 2025
instrumentation/kafka/README.md
Outdated
Comment on lines
7
to
8
| | `otel.instrumentation.messaging.experimental.capture-headers` | List | Empty | Enable the capture of experimental headers in messaging systems. | | ||
| | `otel.instrumentation.messaging.experimental.receive-telemetry.enabled` | Boolean | `false` | Enable the capture of experimental receive telemetry in messaging systems. | |
Contributor
There was a problem hiding this comment.
I think we currently don't list the common options in the readme files.
Contributor
Author
There was a problem hiding this comment.
@laurit I reverted the README because my previous change was unnecessary.
laurit
reviewed
Jul 11, 2025
instrumentation/kafka/kafka-clients/kafka-clients-0.11/metadata.yaml
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 11, 2025
instrumentation/kafka/kafka-clients/kafka-clients-0.11/metadata.yaml
Outdated
Show resolved
Hide resolved
laurit
reviewed
Jul 11, 2025
instrumentation/kafka/kafka-clients/kafka-clients-0.11/metadata.yaml
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this issue, I add missing configurations and a description to the metadata for Kafka 0.11, and write the metadata for Kafka 2.6.
Kafka 0.11 instrumentation is a Java agent module, so its metadata includes a configurations section. In contrast, Kafka 2.6 instrumentation is just a library, so I don’t include any configurations there.
While going through the Kafka README.md, I notice that a few configurations are missing, so I add them as well.