Update the OpenTelemetry SDK version to 1.52.0 #14231
Conversation
github-actions
bot
added
the
test native
|
🔧 The result from spotlessApply was committed to the PR branch. |
| import io.opentelemetry.javaagent.instrumentation.opentelemetryapi.v1_27.logs.LogBridging; | ||
| import io.opentelemetry.javaagent.instrumentation.opentelemetryapi.v1_50.incubator.logs.ApplicationLogger150Incubator; | ||
|
|
||
| @SuppressWarnings("deprecation") // isEnabled() in ExtendedLogger has been deprecated |
There was a problem hiding this comment.
I don't see the no-arg isEnabled() used here?
There was a problem hiding this comment.
It isn't used but errorprone produces the warning nevertheless
../opentelemetry-java-instrumentation/instrumentation/opentelemetry-api/opentelemetry-api-1.52/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opentelemetryapi/v1_52/incubator/logs/ApplicationLogger152Incubator.java:15: warning: [deprecation] isEnabled() in ExtendedLogger has been deprecated
class ApplicationLogger152Incubator extends ApplicationLogger150Incubator
^
1 error
1 warning
perhaps it sees that it is implemented in the super class? If we add
@Override
public boolean isEnabled() {
return agentLogger.isEnabled(io.opentelemetry.api.logs.Severity.UNDEFINED_SEVERITY_NUMBER);
}to this class then we could put the @SuppressWarnings("deprecation") only on that method
Update the OpenTelemetry SDK version to
1.52.0.