Skip to content

Don't require internal class javadoc on test classes #14281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 1 commit into from
Jul 18, 2025
Merged

Don't require internal class javadoc on test classes #14281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conventions/src/main/kotlin/otel.errorprone-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ tasks {
if ((project.path.endsWith(":testing") || name.contains("Test")) && !project.name.equals("custom-checks")) {
// This check causes too many failures, ignore the ones in tests
disable("OtelCanIgnoreReturnValueSuggester")
disable("OtelInternalJavadoc")
}
}
}
Expand Down
1 change: 0 additions & 1 deletion ...entation/kafkaclients/common/v0_11/internal/AbstractOpenTelemetryMetricsReporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
import org.testcontainers.kafka.KafkaContainer;
import org.testcontainers.utility.DockerImageName;

@SuppressWarnings("OtelInternalJavadoc")
@Testcontainers
public abstract class AbstractOpenTelemetryMetricsReporterTest {

Expand Down
1 change: 0 additions & 1 deletion ...opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaClientBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
import org.testcontainers.kafka.KafkaContainer;
import org.testcontainers.utility.DockerImageName;

@SuppressWarnings("OtelInternalJavadoc")
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
public abstract class KafkaClientBaseTest {
private static final Logger logger = LoggerFactory.getLogger(KafkaClientBaseTest.class);
Expand Down
1 change: 0 additions & 1 deletion ...ry/instrumentation/kafkaclients/common/v0_11/internal/KafkaClientPropagationBaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import org.apache.kafka.clients.producer.ProducerRecord;
import org.junit.jupiter.api.Test;

@SuppressWarnings("OtelInternalJavadoc")
public abstract class KafkaClientPropagationBaseTest extends KafkaClientBaseTest {
private static final boolean producerPropagationEnabled =
Boolean.parseBoolean(
Expand Down
1 change: 0 additions & 1 deletion ...va/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaTestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import org.apache.kafka.clients.consumer.Consumer;
import org.apache.kafka.clients.consumer.ConsumerRecords;

@SuppressWarnings("OtelInternalJavadoc")
public class KafkaTestUtil {
private static final Method consumerPollDurationMethod = getConsumerPollDurationMethod();

Expand Down
Loading