add the headers capture feature to Kafka 2.6 interceptors #14290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
reviewed
Jul 20, 2025
...brary/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsTest.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka/kafka-clients/kafka-clients-2.6/metadata.yaml
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Jul 21, 2025
laurit
reviewed
Jul 22, 2025
| @@ -1,2 +1,13 @@ | |||
| description: > | |||
| This instrumentation provides a library integeration that enables messaging spans and metrics for Apache Kafka 2.6+ clients. | |||
| This instrumentation provides both library and wrapper integrations that enable messaging spans and metrics for Apache Kafka 2.6+ clients. | |||
There was a problem hiding this comment.
By library instrumentation we mean a standalone instrumentation that can be used without the agent. wrapper integration isn't part of our terminology. I can understand that you mean that the library offers two kind of instrumentations, one that is based on interceptors and the other one that wraps producers and consumers, but for casual reader imo this sentence does not make sense.
There was a problem hiding this comment.
@laurit The word “wrapper” felt out of place since it wasn’t used anywhere in any metadata.yaml, so I agree it should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kafka 2.6 wrapper library currently supports the header capture feature, but the interceptors are not supported yet.
Additionally, I clarified the Kafka 2.6 metadata, adding that the Kafka 2.6 library can be accessed via either the wrapper or interceptors, and added the missing configuration options.