Instrument openai async client #14322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jul 24, 2025
|
|
||
| public static void emitPromptLogEvents( | ||
| Logger eventLogger, ChatCompletionCreateParams request, boolean captureMessageContent) { | ||
| Context ctx, |
Contributor
There was a problem hiding this comment.
usually we don't use abbreviations so most code uses context and parentContext
laurit
approved these changes
Jul 24, 2025
…-instrumentation into openai-async
anuraaga
commented
Jul 25, 2025
| future = | ||
| future.whenComplete( | ||
| (res, t) -> instrumenter.end(context, chatCompletionCreateParams, res, t)); | ||
| return CompletableFutureWrapper.wrap(future, parentContext); |
Contributor
Author
There was a problem hiding this comment.
I realized I had a big bug here, passing context instead of parentContext. Fixed it and updated test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues openai instrumentation, adding support for async client. The types work out that the proxy entry points need to basically be duplicated but the telemetry is still mostly contained in the instrumentation API usage, and streaming handling was refactored to a sharable class.
Also passes context to logs in all cases which is required for async, and will be a bit faster in sync anyways.
/cc @codefromthecrypt