fix(deps): update errorproneversion to v2.41.0 (minor)

custom-checks/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/CanIgnoreReturnValueSuggesterFactory.java

@@ -6,13 +6,14 @@
 package com.google.errorprone.bugpatterns.checkreturnvalue;
 
 import com.google.errorprone.ErrorProneFlags;
+import com.google.errorprone.bugpatterns.WellKnownKeep;
 
 public final class CanIgnoreReturnValueSuggesterFactory {
 
   // calls package private constructor of CanIgnoreReturnValueSuggester
   public static CanIgnoreReturnValueSuggester createCanIgnoreReturnValueSuggester(
-      ErrorProneFlags errorProneFlags) {
-    return new CanIgnoreReturnValueSuggester(errorProneFlags);
+      ErrorProneFlags errorProneFlags, WellKnownKeep wellKnownKeep) {
+    return new CanIgnoreReturnValueSuggester(errorProneFlags, wellKnownKeep);
   }
 
   private CanIgnoreReturnValueSuggesterFactory() {}

custom-checks/src/main/java/io/opentelemetry/javaagent/customchecks/OtelCanIgnoreReturnValueSuggester.java

@@ -12,6 +12,7 @@
 import com.google.errorprone.ErrorProneFlags;
 import com.google.errorprone.VisitorState;
 import com.google.errorprone.bugpatterns.BugChecker;
+import com.google.errorprone.bugpatterns.WellKnownKeep;
 import com.google.errorprone.bugpatterns.checkreturnvalue.CanIgnoreReturnValueSuggester;
 import com.google.errorprone.bugpatterns.checkreturnvalue.CanIgnoreReturnValueSuggesterFactory;
 import com.google.errorprone.matchers.Description;
@@ -33,9 +34,10 @@ public class OtelCanIgnoreReturnValueSuggester extends BugChecker
   private final CanIgnoreReturnValueSuggester delegate;
 
   @Inject
-  OtelCanIgnoreReturnValueSuggester(ErrorProneFlags errorProneFlags) {
+  OtelCanIgnoreReturnValueSuggester(ErrorProneFlags errorProneFlags, WellKnownKeep wellKnownKeep) {
     delegate =
-        CanIgnoreReturnValueSuggesterFactory.createCanIgnoreReturnValueSuggester(errorProneFlags);
+        CanIgnoreReturnValueSuggesterFactory.createCanIgnoreReturnValueSuggester(
+            errorProneFlags, wellKnownKeep);
   }
 
   public OtelCanIgnoreReturnValueSuggester() {

dependencyManagement/build.gradle.kts

@@ -38,7 +38,7 @@ val DEPENDENCY_BOMS = listOf(
 
 val autoServiceVersion = "1.1.1"
 val autoValueVersion = "1.11.0"
-val errorProneVersion = "2.40.0"
+val errorProneVersion = "2.41.0"
 val byteBuddyVersion = "1.17.6"
 val asmVersion = "9.8"
 val jmhVersion = "1.37"

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ContextPropagationDebug.java

@@ -139,10 +139,10 @@ private static void debugContextPropagation(Context context) {
   }
 
   private static class Propagation {
-    public final String carrierClassName;
-    public final StackTraceElement[] location;
+    final String carrierClassName;
+    final StackTraceElement[] location;
 
-    public Propagation(String carrierClassName, StackTraceElement[] location) {
+    Propagation(String carrierClassName, StackTraceElement[] location) {
       this.carrierClassName = carrierClassName;
       this.location = location;
     }

instrumentation/akka/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/server/AkkaFlowWrapper.java

@@ -73,7 +73,7 @@ public GraphStageLogic createLogic(Attributes attributes) {
   private class TracingLogic extends GraphStageLogic {
     private final Deque<TracingRequest> requests = new ArrayDeque<>();
 
-    public TracingLogic() {
+    TracingLogic() {
       super(shape);
 
       // server pulls response, pass response from user code to server

instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientTest.java

@@ -211,7 +211,7 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
   private static class HttpResponseHandler implements ResponseHandler<Void> {
     private final HttpClientResult requestResult;
 
-    public HttpResponseHandler(HttpClientResult requestResult) {
+    HttpResponseHandler(HttpClientResult requestResult) {
       this.requestResult = requestResult;
     }
 

instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpAsyncClientTest.java

@@ -127,7 +127,7 @@ void executeRequestWithCallback(SimpleHttpRequest request, URI uri, HttpClientRe
   private static class ResponseCallback implements FutureCallback<SimpleHttpResponse> {
     private final HttpClientResult httpClientResult;
 
-    public ResponseCallback(HttpClientResult httpClientResult) {
+    ResponseCallback(HttpClientResult httpClientResult) {
       this.httpClientResult = httpClientResult;
     }
 

instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientTest.java

@@ -234,7 +234,7 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
   private static class ResponseHandler implements HttpClientResponseHandler<Void> {
     private final HttpClientResult httpClientResult;
 
-    public ResponseHandler(HttpClientResult httpClientResult) {
+    ResponseHandler(HttpClientResult httpClientResult) {
       this.httpClientResult = httpClientResult;
     }
 

instrumentation/aws-lambda/aws-lambda-events-2.2/library/src/test/java/io/opentelemetry/instrumentation/awslambdaevents/v2_2/AwsLambdaWrapperTest.java

@@ -177,8 +177,7 @@ public String handleRequest(Integer input, Context context) {
     }
   }
 
-  @SuppressWarnings("UnusedMethod")
-  private static class CustomType {
+  static class CustomType {
     String key;
     String value;
 

instrumentation/aws-sdk/aws-sdk-1.11/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v1_11/TracingList.java

@@ -85,7 +85,7 @@ private Object writeReplace() {
   }
 
   private static class CallerClass extends SecurityManager {
-    public static final CallerClass INSTANCE = new CallerClass();
+    static final CallerClass INSTANCE = new CallerClass();
 
     @Override
     public Class<?>[] getClassContext() {

instrumentation/camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/ActiveContextManager.java

@@ -83,25 +83,24 @@ private static class ContextWithScope {
     private final CamelRequest request;
     @Nullable private final Scope scope;
 
-    public ContextWithScope(
-        ContextWithScope parent, Context context, CamelRequest request, Scope scope) {
+    ContextWithScope(ContextWithScope parent, Context context, CamelRequest request, Scope scope) {
       this.parent = parent;
       this.context = context;
       this.request = request;
       this.scope = scope;
     }
 
-    public static ContextWithScope activate(
+    static ContextWithScope activate(
         ContextWithScope parent, Context context, CamelRequest request) {
       Scope scope = context != null ? context.makeCurrent() : null;
       return new ContextWithScope(parent, context, request, scope);
     }
 
-    public ContextWithScope getParent() {
+    ContextWithScope getParent() {
       return parent;
     }
 
-    public void deactivate(Exception exception) {
+    void deactivate(Exception exception) {
       if (scope == null) {
         return;
       }

instrumentation/camel-2.20/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachecamel/aws/SnsCamelTest.java

@@ -174,7 +174,7 @@ private static final class SnsMetadata {
     private final String queueUrl;
     private final String topicArn;
 
-    public SnsMetadata(String queueUrl, String topicArn) {
+    SnsMetadata(String queueUrl, String topicArn) {
       this.queueUrl = queueUrl;
       this.topicArn = topicArn;
     }

instrumentation/cassandra/cassandra-3.0/javaagent/src/test/java/CassandraClientTest.java

@@ -340,14 +340,14 @@ private static Stream<Arguments> provideAsyncParameters() {
   }
 
   private static class Parameter {
-    public final String keyspace;
-    public final String statement;
-    public final String expectedStatement;
-    public final String spanName;
-    public final String operation;
-    public final String table;
+    final String keyspace;
+    final String statement;
+    final String expectedStatement;
+    final String spanName;
+    final String operation;
+    final String table;
 
-    public Parameter(
+    Parameter(
         String keyspace,
         String statement,
         String expectedStatement,

instrumentation/couchbase/couchbase-2-common/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/couchbase/v2_0/CouchbaseQuerySanitizerTest.java

@@ -72,10 +72,10 @@ private static Stream<Arguments> providesArguments() {
   }
 
   private static class Parameter {
-    public final Object query;
-    public final String expected;
+    final Object query;
+    final String expected;
 
-    public Parameter(Object query, String expected) {
+    Parameter(Object query, String expected) {
       this.query = query;
       this.expected = expected;
     }

instrumentation/elasticsearch/elasticsearch-api-client-7.16/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/apiclient/ElasticsearchClientTest.java

@@ -212,19 +212,19 @@ void elasticsearchStatusAsync() throws Exception {
   }
 
   private static class AsyncRequest {
-    volatile InfoResponse response = null;
+    private volatile InfoResponse response = null;
 
-    public InfoResponse getResponse() {
+    InfoResponse getResponse() {
       return response;
     }
 
-    public void setResponse(InfoResponse response) {
+    void setResponse(InfoResponse response) {
       this.response = response;
     }
   }
 
-  private static class Person {
-    public final String name;
+  static class Person {
+    private final String name;
 
     Person(String name) {
       this.name = name;

instrumentation/elasticsearch/elasticsearch-rest-7.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java

@@ -183,22 +183,22 @@ public void onFailure(Exception e) {
   }
 
   private static class AsyncRequest {
-    volatile Response requestResponse = null;
-    volatile Exception exception = null;
+    private volatile Response requestResponse = null;
+    private volatile Exception exception = null;
 
-    public Response getRequestResponse() {
+    Response getRequestResponse() {
       return requestResponse;
     }
 
-    public void setRequestResponse(Response requestResponse) {
+    void setRequestResponse(Response requestResponse) {
       this.requestResponse = requestResponse;
     }
 
-    public Exception getException() {
+    Exception getException() {
       return exception;
     }
 
-    public void setException(Exception exception) {
+    void setException(Exception exception) {
       this.exception = exception;
     }
   }

instrumentation/elasticsearch/elasticsearch-rest-7.0/library/src/test/java/io/opentelemetry/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java

@@ -159,22 +159,22 @@ public void onFailure(Exception e) {
   }
 
   private static class AsyncRequest {
-    volatile Response requestResponse = null;
-    volatile Exception exception = null;
+    private volatile Response requestResponse = null;
+    private volatile Exception exception = null;
 
-    public Response getRequestResponse() {
+    Response getRequestResponse() {
       return requestResponse;
     }
 
-    public void setRequestResponse(Response requestResponse) {
+    void setRequestResponse(Response requestResponse) {
       this.requestResponse = requestResponse;
     }
 
-    public Exception getException() {
+    Exception getException() {
       return exception;
     }
 
-    public void setException(Exception exception) {
+    void setException(Exception exception) {
       this.exception = exception;
     }
   }

instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/elasticsearch6Test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/Elasticsearch6NodeFactory.java

@@ -18,7 +18,7 @@ public Node newNode(Settings settings) {
         InternalSettingsPreparer.prepareEnvironment(settings, null),
         Collections.singleton(Netty4Plugin.class)) {
 
-      @SuppressWarnings({"UnusedMethod", "UnusedVariable"})
+      @SuppressWarnings({"UnusedMethod", "UnusedVariable", "EffectivelyPrivate"})
       protected void registerDerivedNodeNameWithLogger(String s) {}
     };
   }

instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTest.java

@@ -176,7 +176,7 @@ private static class CustomAttributesExtractorV2
 
     private final String valueOfKey2;
 
-    public CustomAttributesExtractorV2(String valueOfKey2) {
+    CustomAttributesExtractorV2(String valueOfKey2) {
       this.valueOfKey2 = valueOfKey2;
     }
 

instrumentation/hibernate/hibernate-3.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v3_3/QueryTest.java

@@ -140,11 +140,11 @@ private static Stream<Arguments> provideArguments() {
   }
 
   private static class Parameter {
-    public final String expectedSpanName;
-    public final boolean requiresTransaction;
-    public final Consumer<Session> queryInteraction;
+    final String expectedSpanName;
+    final boolean requiresTransaction;
+    final Consumer<Session> queryInteraction;
 
-    public Parameter(
+    Parameter(
         String expectedSpanName, boolean requiresTransaction, Consumer<Session> queryInteraction) {
       this.expectedSpanName = expectedSpanName;
       this.requiresTransaction = requiresTransaction;

instrumentation/hibernate/hibernate-3.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v3_3/SessionTest.java

@@ -576,13 +576,13 @@ private static Stream<Arguments> provideArgumentsForQueryMethods() {
   }
 
   private static class Parameter {
-    public final String methodName;
-    public final String resource;
-    public final BiConsumer<Session, Value> sessionMethodTest;
-    public final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
-    public final Function<Session, Query> queryBuildMethod;
+    final String methodName;
+    final String resource;
+    final BiConsumer<Session, Value> sessionMethodTest;
+    final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
+    final Function<Session, Query> queryBuildMethod;
 
-    public Parameter(
+    Parameter(
         String methodName,
         String resource,
         BiConsumer<Session, Value> sessionMethodTest,

instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/EntityManagerTest.java

@@ -371,12 +371,12 @@ private static Stream<Arguments> provideArgumentsAttachesState() {
   }
 
   private static class Parameter {
-    public final String methodName;
-    public final boolean attach;
-    public final boolean flushOnCommit;
-    public final BiConsumer<EntityManager, Value> sessionMethodTest;
+    final String methodName;
+    final boolean attach;
+    final boolean flushOnCommit;
+    final BiConsumer<EntityManager, Value> sessionMethodTest;
 
-    public Parameter(
+    Parameter(
         String methodName,
         boolean attach,
         boolean flushOnCommit,

instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/QueryTest.java

@@ -225,10 +225,10 @@ void testHibernateQueryIterate() {
   }
 
   private static class Parameter {
-    public final String expectedSpanName;
-    public final Consumer<Session> queryInteraction;
+    final String expectedSpanName;
+    final Consumer<Session> queryInteraction;
 
-    public Parameter(String expectedSpanName, Consumer<Session> queryInteraction) {
+    Parameter(String expectedSpanName, Consumer<Session> queryInteraction) {
       this.expectedSpanName = expectedSpanName;
       this.queryInteraction = queryInteraction;
     }

instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/SessionTest.java

@@ -851,11 +851,11 @@ void testHibernateOverlappingSessions() {
   }
 
   private static class Parameter {
-    public final String methodName;
-    public final BiConsumer<Session, Value> sessionMethodTest;
-    public final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
+    final String methodName;
+    final BiConsumer<Session, Value> sessionMethodTest;
+    final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
 
-    public Parameter(
+    Parameter(
         String methodName,
         BiConsumer<Session, Value> sessionMethodTest,
         BiConsumer<StatelessSession, Value> statelessSessionMethodTest) {