Skip to content

Use weaver to generate OSHI metrics #14346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Jul 29, 2025

Inspired by open-telemetry/opentelemetry-java-contrib#1960

This is an experiment to play with using weaver to generate metrics and documentation.

A couple thoughts:

  • It still isn't clear to me the best approach to using weaver in a repo like this where there might be multiple registries, I plan on talking about this in the weaver SIG meeting
  • There is a lot of boilerplate in terms of the jinja templates, going to explore how we might be able to create/leverage them in a re-usable manner so we don't need to duplicate them for every module
  • For the metrics generated from this do not follow semantic conventions, should their stability be experimental instead of development? I think so, but wanted to double check (runtime.java.cpu_time etc).
  • There is an open issue (Move oshi instrumentation to contrib repo and package as agent extension #9517) to move this to the contrib repo, perhaps it would make sense to do that so we could then experiment with re-usable pieces

I am still working on figuring out how this overlaps/interops with the existing metadata project, but wanted to get something moving so we can see how weaver integrates with this codebase.

@jaydeluca jaydeluca requested a review from a team as a code owner July 29, 2025 13:11
@jaydeluca jaydeluca marked this pull request as draft July 31, 2025 17:09
@laurit
Copy link
Contributor

laurit commented Aug 11, 2025

I find it hard to justify the complexity. I'd just keep the java code and doc in sync manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants