More metadata for another batch of instrumentations #14399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Aug 11, 2025
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
There is also an additional feature added
can you split this feature out into separate PR and include one usage of it (e.g. armeria grpc)?
|
|
||
| val testStableSemconv by registering(Test::class) { | ||
| jvmArgs("-Dotel.semconv-stability.opt-in=database") | ||
| systemProperty("metaDataConfig", "otel.semconv-stability.opt-in=database") |
Member
There was a problem hiding this comment.
nit: metadataConfig (can be in followup)
jaydeluca
changed the title
trask
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468 and #14096
Adds descriptions to more modules, additional details for configuration descriptions for experiment attributes, and enables telemetry collection for more instrumentations.