Metadata Telemetry scope allowlist #14413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468
There are some instrumentations that use instrumenters or Telemetry classes from other instrumentation modules, and the resulting telemetry has a scope that does not match the instrumentation name. For example, the
armeria-grpc-1.14instrumentation installs Client and server interceptors from the grpc-1.6 instrumenation library, and therefore the resulting spans have a scope ofio.opentelemetry.grpc-1.6This causes issues with the
SpanParserwhen trying to show telemetry emitted, because we are filtering out all telemetry signals that don't match the scope of the instrumentation module we are processing.I think in cases like this, it's useful to have that telemetry documented, even if the scope doesn't match, since it is
armeria-grpc-1.14installing those filters and enabling the telemetry.So I added a new capability to specify a
scopeAllowListso that you can define additional scopes to include in telemetry collection for a given scope (for example to allow showing the telemetry fromgrpc-1.6forarmeria-grpc-1.14).