Avoid failures on spring boot 4-m1 #14420
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
|
Great! We should have at least a unit or integration test. |
We usually don't test milestone versions. The intent of this PR is not to offer full support for spring boot m1 but rather to avoid our starter breaking with it. If you so wish you can add the tests and implement the missing functionality, but we could also do it at a later time when spring boot 4 has been released or when there is a release candidate. |
jaydeluca
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14363
A bunch of classes move to different package in spring boot 4. This will hopefully avoid class loading exceptions, but the instrumentations will not function with boot 4.