Skip to content

Fix dropwizard-views configuration #14475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

Fix dropwizard-views configuration #14475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a4970
Fix dropwizard-views configuration
jaydeluca Aug 20, 2025
7f97275
update changelog
jaydeluca Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

### Migration notes

- The configuration option used to enable traces generated by the `dropwizard-views` instrumentation has changed from `otel.instrumentation.common.experimental.controller-telemetry.enabled` to `otel.instrumentation.common.experimental.view-telemetry.enabled`
([#14475](https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/14475))

## Version 2.19.0 (2025-08-17)

### 📈 Enhancements
Expand Down
4 changes: 0 additions & 4 deletions docs/instrumentation-list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2269,10 +2269,6 @@ libraries:
description: Enables the creation of experimental view (INTERNAL) spans.
type: boolean
default: false
- name: otel.instrumentation.common.experimental.controller-telemetry.enabled
description: Enables the creation of experimental controller (INTERNAL) spans.
type: boolean
default: false
elasticsearch:
- name: elasticsearch-api-client-7.16
description: This instrumentation enables client spans for Elasticsearch API client
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/dropwizard/dropwizard-views-0.7/javaagent/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ dependencies {
}

tasks.withType<Test>().configureEach {
jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
jvmArgs("-Dotel.instrumentation.common.experimental.view-telemetry.enabled=true")
}
2 changes: 1 addition & 1 deletion ...java/io/opentelemetry/javaagent/instrumentation/dropwizardviews/DropwizardSingletons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public final class DropwizardSingletons {
private static final Instrumenter<View, Void> INSTRUMENTER =
Instrumenter.<View, Void>builder(
GlobalOpenTelemetry.get(), INSTRUMENTATION_NAME, DropwizardSingletons::spanName)
.setEnabled(ExperimentalConfig.get().controllerTelemetryEnabled())
.setEnabled(ExperimentalConfig.get().viewTelemetryEnabled())
.buildInstrumenter();

private static String spanName(View view) {
Expand Down
4 changes: 0 additions & 4 deletions instrumentation/dropwizard/dropwizard-views-0.7/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,3 @@ configurations:
description: Enables the creation of experimental view (INTERNAL) spans.
type: boolean
default: false
- name: otel.instrumentation.common.experimental.controller-telemetry.enabled
description: Enables the creation of experimental controller (INTERNAL) spans.
type: boolean
default: false