Skip to content

Remove gradle spring boot plugin usage from common smoke test modules #14487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

Remove gradle spring boot plugin usage from common smoke test modules #14487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions smoke-tests-otel-starter/spring-boot-common/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import org.springframework.boot.gradle.tasks.bundling.BootJar

plugins {
id("otel.java-conventions")
id("org.springframework.boot") version "2.6.15"
}

description = "smoke-tests-otel-starter-spring-boot-common"

dependencies {
// spring dependencies are compile only to enable testing against different versions of spring
compileOnly(platform(org.springframework.boot.gradle.plugin.SpringBootPlugin.BOM_COORDINATES))
compileOnly(platform("org.springframework.boot:spring-boot-dependencies:2.6.15"))
compileOnly("org.springframework.boot:spring-boot-starter-web")
compileOnly("org.springframework.boot:spring-boot-starter-test")
compileOnly("org.springframework.boot:spring-boot-starter-data-jdbc")
Expand All @@ -27,6 +24,11 @@ dependencies {
implementation(project(":instrumentation:spring:starters:spring-boot-starter"))
}

tasks.withType<BootJar> {
enabled = false
tasks {
compileJava {
with(options) {
// preserve parameter names for @SpanAttribute
compilerArgs.add("-parameters")
}
}
}
9 changes: 1 addition & 8 deletions smoke-tests-otel-starter/spring-boot-reactive-common/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
import org.springframework.boot.gradle.tasks.bundling.BootJar

plugins {
id("otel.java-conventions")
id("org.springframework.boot") version "2.6.15"
}

description = "smoke-tests-otel-starter-spring-boot-reactive-common"

dependencies {
// spring dependencies are compile only to enable testing against different versions of spring
compileOnly(platform(org.springframework.boot.gradle.plugin.SpringBootPlugin.BOM_COORDINATES))
compileOnly(platform("org.springframework.boot:spring-boot-dependencies:2.6.15"))
compileOnly("org.springframework.boot:spring-boot-starter-web")
compileOnly("org.springframework.boot:spring-boot-starter-webflux")
compileOnly("org.springframework.boot:spring-boot-starter-test")
compileOnly("org.springframework.boot:spring-boot-starter-data-r2dbc")
api(project(":smoke-tests-otel-starter:spring-smoke-testing"))
}

tasks.withType<BootJar> {
enabled = false
}
9 changes: 1 addition & 8 deletions smoke-tests-otel-starter/spring-smoke-testing/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
import org.springframework.boot.gradle.tasks.bundling.BootJar

plugins {
id("otel.java-conventions")
id("org.springframework.boot") version "2.6.15"
}

description = "smoke-tests-otel-starter-spring-smoke-testing"

dependencies {
// spring dependencies are compile only to enable testing against different versions of spring
compileOnly(platform(org.springframework.boot.gradle.plugin.SpringBootPlugin.BOM_COORDINATES))
compileOnly(platform("org.springframework.boot:spring-boot-dependencies:2.6.15"))
compileOnly("org.springframework.boot:spring-boot-starter")
compileOnly("org.springframework.boot:spring-boot-starter-test")
api(project(":testing-common"))
api("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi")
implementation("com.google.guava:guava")
}

tasks.withType<BootJar> {
enabled = false
}