Skip to content

Test mixed case header capture for kafka interceptors #14529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
+5 −5
Merged

Test mixed case header capture for kafka interceptors #14529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ tasks {
excludeTestsMatching("WrapperSuppressReceiveSpansTest")
}
jvmArgs("-Dotel.instrumentation.messaging.experimental.receive-telemetry.enabled=true")
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "test-message-header")
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "Test-Message-Header")
}

check {
Expand Down
2 changes: 1 addition & 1 deletion ...est/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractInterceptorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void testInterceptors() throws InterruptedException {
producerRecord
.headers()
// add header to test capturing header value as span attribute
.add("test-message-header", "test".getBytes(StandardCharsets.UTF_8))
.add("Test-Message-Header", "test".getBytes(StandardCharsets.UTF_8))
// adding baggage header in w3c baggage format
.add(
"baggage",
Expand Down
6 changes: 3 additions & 3 deletions ...ry/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void assertTraces() {
.hasParent(trace.getSpan(0))
.hasAttributesSatisfyingExactly(
equalTo(
stringArrayKey("messaging.header.test_message_header"),
stringArrayKey("messaging.header.Test_Message_Header"),
singletonList("test")),
equalTo(MESSAGING_SYSTEM, "kafka"),
equalTo(MESSAGING_DESTINATION_NAME, SHARED_TOPIC),
Expand All @@ -70,7 +70,7 @@ void assertTraces() {
.hasLinksSatisfying(links -> assertThat(links).isEmpty())
.hasAttributesSatisfyingExactly(
equalTo(
stringArrayKey("messaging.header.test_message_header"),
stringArrayKey("messaging.header.Test_Message_Header"),
singletonList("test")),
equalTo(MESSAGING_SYSTEM, "kafka"),
equalTo(MESSAGING_DESTINATION_NAME, SHARED_TOPIC),
Expand All @@ -87,7 +87,7 @@ void assertTraces() {
.hasLinks(LinkData.create(producerSpanContext.get()))
.hasAttributesSatisfyingExactly(
equalTo(
stringArrayKey("messaging.header.test_message_header"),
stringArrayKey("messaging.header.Test_Message_Header"),
singletonList("test")),
equalTo(MESSAGING_SYSTEM, "kafka"),
equalTo(MESSAGING_DESTINATION_NAME, SHARED_TOPIC),
Expand Down
Loading