Skip to content

Conversation

@jaydeluca
Copy link
Member

Some recent changes around case sensitivity added some new headers in tests that we need to exclude so we don't populate our output with them.

This is what was being added that this PR fixes:

       spans:
       - span_kind: CONSUMER
         attributes:
+        - name: messaging.header.Test_Message_Header
+          type: STRING_ARRAY
         - name: messaging.operation
           type: STRING

....

         attributes:
         - name: messaging.destination.name
           type: STRING
+        - name: messaging.header.Test_Message_Int_Header
+          type: STRING_ARRAY

@SylvainJuge
Copy link
Contributor

FYI, the header normalization is also likely being impacted by #14554. Should the metadata reflect the default behavior or is there a way to handle opt-in configuration options as well ?

@jaydeluca
Copy link
Member Author

FYI, the header normalization is also likely being impacted by #14554.

@SylvainJuge thanks for the heads up! I will get ahead of that change and add that to the exclusion list too.

Should the metadata reflect the default behavior or is there a way to handle opt-in configuration options as well ?

I think in this particular case it doesn't apply, because the header normalization functionality only affects custom attributes, which we don't currently document in our metadata / final instrumentation list.

To answer the question more generally though, for emitted telemetry and attributes we can differentiate using the when blocks. It's not perfect, but it provides some insight into the variability of behavior the opt-in configs provide. Is that what you meant? Or did you have something else in mind where the metadata can also be dynamic?

@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@trask trask merged commit a278255 into open-telemetry:main Sep 4, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants