declarative config: map common-enabled #14589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trask please have a look |
jaydeluca
reviewed
Sep 8, 2025
javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/OpenTelemetryInstaller.java
Outdated
Show resolved
Hide resolved
|
🔧 The result from spotlessApply was committed to the PR branch. |
jaydeluca
approved these changes
Sep 8, 2025
laurit
approved these changes
Sep 11, 2025
trask
reviewed
Sep 11, 2025
| if (fail) { | ||
| assertThatCode(() -> configPropertiesSupplier.get()) | ||
| .isInstanceOf(ConfigurationException.class) | ||
| .hasMessage("Unknown instrumentation profile: invalid"); |
There was a problem hiding this comment.
Suggested change
| .hasMessage("Unknown instrumentation profile: invalid"); | |
| .hasMessage("Unknown instrumentation mode: invalid"); |
trask
reviewed
Sep 11, 2025
| }) | ||
| void defaultEnabledInDeclarativeConfigPropertiesBridge( | ||
| String propertyValue, boolean expected, boolean fail) { | ||
| String profile = propertyValue == null ? "" : "instrumentation_mode: \"" + propertyValue + "\""; |
|
follow up with cleanups: #14641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14432