convert groovy smoke test to java, part 2 #14683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
zeitlinger
changed the title
Member
Author
|
@laurit should I add more tests - or would you rather review this batch first? |
Contributor
Lets do this batch first. |
laurit
reviewed
Sep 18, 2025
smoke-tests/src/main/java/io/opentelemetry/smoketest/JavaTelemetryRetriever.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 18, 2025
laurit
reviewed
Sep 18, 2025
testing-common/src/main/java/io/opentelemetry/instrumentation/testing/junit/MetricsAssert.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Follow up to add SmokeTestTarget builder is #14708 |
laurit
approved these changes
Sep 19, 2025
mznet
pushed a commit
to mznet/opentelemetry-java-instrumentation
that referenced
this pull request
Sep 26, 2025
Co-authored-by: otelbot <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.