Skip to content

Conversation

@zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Sep 21, 2025

No description provided.

@zeitlinger zeitlinger self-assigned this Sep 21, 2025
@zeitlinger zeitlinger requested a review from a team as a code owner September 21, 2025 07:29
@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@zeitlinger zeitlinger changed the title Convert app server smoke tests Convert remaining smoke tests Sep 21, 2025
@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@zeitlinger
Copy link
Member Author

@laurit please take a look

@laurit
Copy link
Contributor

laurit commented Sep 23, 2025

@laurit please take a look

I'm not convinced that adding everything to the SmokeTestExtension is a good idea. Ideally that extension could also be used by others, making it specific to our smoke tests limits its usefulness. Also instead of the custom AppServer annotations that we used in groovy tests it might be more straightforward to use parameterized tests. Need to think more about this.

@zeitlinger
Copy link
Member Author

I'm not convinced that adding everything to the SmokeTestExtension is a good idea.

the version with the superclass got too confusing - but maybe you have an idea

Also instead of the custom AppServer annotations that we used in groovy tests it might be more straightforward to use parameterized tests. Need to think more about this.

Also thought about this one: I think it would be possible, but you'd have to start the app server once for each test rather than for all tests together.

@zeitlinger
Copy link
Member Author

I'm not convinced that adding everything to the SmokeTestExtension is a good idea

we can also keep the extension as it is now (57 lines including commets) and rename the extension in this PR to something else.

@zeitlinger
Copy link
Member Author

closed in favor of #14795

@zeitlinger zeitlinger closed this Sep 25, 2025
@zeitlinger zeitlinger deleted the convert-smoke-tests3 branch September 25, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants