-
Notifications
You must be signed in to change notification settings - Fork 1k
Convert remaining smoke tests #14731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
@laurit please take a look |
I'm not convinced that adding everything to the SmokeTestExtension is a good idea. Ideally that extension could also be used by others, making it specific to our smoke tests limits its usefulness. Also instead of the custom AppServer annotations that we used in groovy tests it might be more straightforward to use parameterized tests. Need to think more about this. |
the version with the superclass got too confusing - but maybe you have an idea
Also thought about this one: I think it would be possible, but you'd have to start the app server once for each test rather than for all tests together. |
we can also keep the extension as it is now (57 lines including commets) and rename the extension in this PR to something else. |
|
closed in favor of #14795 |
No description provided.