Skip to content

Conversation

@hoteye
Copy link
Contributor

@hoteye hoteye commented Sep 22, 2025

PR: Remove outdated TODO comments for contrib 1.50.0 update

Description

This PR cleans up outdated TODO comments and removes duplicate configuration that is no longer needed.

Changes

  • Removed TODO comments mentioning "remove after updating contrib to 1.50.0"
  • Removed duplicate filesMatching configuration for GCP resource version.properties in two shadow jar tasks
  • Simplified build configuration by removing unnecessary duplicate handling

Justification

The TODO comments reference updating to contrib 1.50.0, but the project is already using OpenTelemetry API 1.50.0:

  • instrumentation/opentelemetry-api/opentelemetry-api-1.50/ directory exists and is actively used
  • opentelemetry-api-shaded-for-instrumenting uses 1.50.0-alpha
  • These TODOs are outdated and the duplicate configuration was causing unnecessary complexity

Type of change

  • Cleanup / Refactoring
  • Removes dead code

Testing

  • Build configuration simplified without functionality change
  • No test changes needed as this only removes outdated build configuration
  • Gradle syntax is valid (verified)

Checklist

  • My changes generate no new warnings
  • I have made corresponding changes to the documentation (N/A - internal build config)
  • My changes follow the style guidelines of this project
  • I have performed a self-review of my own code

- Remove TODO comments about updating to contrib 1.50.0
- Remove duplicate GCP resource version.properties handling
- Project is already using OpenTelemetry API 1.50.0 as evidenced in:
  - instrumentation/opentelemetry-api/opentelemetry-api-1.50/
  - opentelemetry-api-shaded-for-instrumenting uses 1.50.0-alpha

These TODO items are no longer relevant and the duplicate
configuration was causing unnecessary complexity in the build.
@hoteye hoteye requested a review from a team as a code owner September 22, 2025 05:57
@laurit
Copy link
Contributor

laurit commented Sep 22, 2025

The TODO comments reference updating to contrib 1.50.0, but the project is already using OpenTelemetry API 1.50.0:

Contrib and api are different projects. Contrib version hasn't been updated yet.

@hoteye
Copy link
Contributor Author

hoteye commented Sep 22, 2025

Thanks for the clarification!.

@hoteye hoteye closed this Sep 22, 2025
@hoteye hoteye deleted the cleanup-outdated-todo-comments branch September 22, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants