Skip to content

fix(test): streamline Dubbo test setup for in-JVM calls #14743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2025
Merged

fix(test): streamline Dubbo test setup for in-JVM calls #14743

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
672512e
fix(test): streamline Dubbo test setup for in-JVM calls
steverao Sep 22, 2025
303a405
./gradlew spotlessApply
otelbot[bot] Sep 22, 2025
f003d6e
Update instrumentation/apache-dubbo-2.7/testing/src/main/java/io/open…
laurit Sep 22, 2025
bfd2a2c
Update instrumentation/apache-dubbo-2.7/testing/src/main/java/io/open…
steverao Sep 23, 2025
555417d
Update instrumentation/apache-dubbo-2.7/testing/src/main/java/io/open…
steverao Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions ...n/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/AbstractDubboTraceChainTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,39 +375,29 @@ void testDubboChain() throws ReflectiveOperationException {
@Test
@DisplayName("test ignore injvm calls")
void testDubboChainInJvm() throws ReflectiveOperationException {
int port = PortUtils.findOpenPorts(2);
int middlePort = port + 1;

// setup hello service provider
ProtocolConfig protocolConfig = new ProtocolConfig();
protocolConfig.setPort(port);

DubboBootstrap bootstrap = DubboTestUtil.newDubboBootstrap();
cleanup.deferCleanup(bootstrap::destroy);
bootstrap
.application(new ApplicationConfig("dubbo-test-provider"))
.service(configureServer())
.protocol(protocolConfig)
.start();
int port = PortUtils.findOpenPort();

// setup middle service provider, hello service consumer
// setup middle service provider with HelloService provider and consumer in same bootstrap for
// in-JVM calls
ProtocolConfig middleProtocolConfig = new ProtocolConfig();
middleProtocolConfig.setPort(middlePort);
middleProtocolConfig.setPort(port);

ReferenceConfig<HelloService> clientReference = configureLocalClient(port);
DubboBootstrap middleBootstrap = DubboTestUtil.newDubboBootstrap();
cleanup.deferCleanup(middleBootstrap::destroy);
middleBootstrap
.application(new ApplicationConfig("dubbo-demo-middle"))
.service(configureMiddleServer(clientReference))
.service(configureServer()) // HelloService provider in same bootstrap
.reference(clientReference) // HelloService consumer using in-JVM calls
.service(configureMiddleServer(clientReference)) // MiddleService provider
.protocol(middleProtocolConfig)
.start();

// setup middle service consumer
ProtocolConfig consumerProtocolConfig = new ProtocolConfig();
consumerProtocolConfig.setRegister(false);

ReferenceConfig<MiddleService> middleReference = configureMiddleClient(middlePort);
ReferenceConfig<MiddleService> middleReference = configureMiddleClient(port);
DubboBootstrap consumerBootstrap = DubboTestUtil.newDubboBootstrap();
cleanup.deferCleanup(consumerBootstrap::destroy);
consumerBootstrap
Expand Down
Loading