-
Notifications
You must be signed in to change notification settings - Fork 1k
Create AI coding agent instructions for OpenTelemetry Java Instrumentation #14770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot use the agents.md format (https://agents.md/) in your output as to generalize for any agent, not just copilot |
…va Instrumentation Co-authored-by: jaydeluca <[email protected]>
Co-authored-by: jaydeluca <[email protected]>
Converted to agents.md format as requested. Renamed the file from copilot-instructions.md to agents.md and the content is now agent-agnostic, suitable for any AI coding agent. Commit: 717ea0a Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
🔧 The result from generateLicenseReport was committed to the PR branch. |
… emphasize testing framework Co-authored-by: jaydeluca <[email protected]>
|
I'm curious why this PR was closed? If we can improve the instructions, for example, by documenting things to note when developing new instrumentations or things to keep in mind when reviewing code, we might be able to solve the current problem of insufficient manpower for code review. |
|
@steverao I closed it because it was getting old without any movement for a couple months, and we hadn't been using copilot for code reviews, so figured we could just re-open if there was a need for it in the future. Also I think the contents are questionable in terms of how valuable they are, but it might be an ok starting point to iterate on. Happy to re-open this, or start a new one if we want |
|
sorry for not commenting, still getting a handle on it all. In general copilot seems to get a lot of the basics fine on its own, and so I'd suggest limiting the agent instructions to known issues (to not clutter the context, which has downsides other than just token usage). e.g. I have just these two instructions locally because copilot (well, the models I'm using?) get these wrong a lot for me: (and even with these, it did both of these things to me today, so 🤷) |
Updated the agent instructions to follow the agents.md format standard to generalize for any AI coding agent, not just GitHub Copilot.
Plan
Completed Work
ci-collect.shfor better parallelismremoveJarVersionNumbersconfiguration./gradlew testdescription and added./gradlew checkcommand-Ddev=trueflag from test commands where not neededKey Features
The instructions are now generalized to work with any AI coding agent, not just GitHub Copilot, while maintaining all the technical accuracy and comprehensive guidance. All feedback from reviewers has been addressed.
Fixes #14769.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.