Add JDBC URL parsing support for OceanBase, PolarDB and Lindorm #14790

pepeshore · 2025-09-25T08:01:34Z

Resolved #14702

Change-Id: Ia3b5f6b74b40763c4df7fa0185223575a2c1b068

…rser

linux-foundation-easycla · 2025-09-25T08:01:41Z

The committers listed above are authorized under a signed CLA.

✅ login: laurit / name: Lauri Tulmin (87105b6, 92a0e4c)
✅ login: otelbot[bot] / name: otelbot (73286f8, 8d79717, ae6a467)
✅ login: pepeshore / name: pepeshore (d0acc07)
✅ login: pepeshore / name: wu.cc (28c2324, 4251ef4, 548e0df, 660f26b, 8282947, a4a325f, e5d0f3c)

otelbot-java-instrumentation · 2025-09-25T08:07:55Z

🔧 The result from spotlessApply was committed to the PR branch.

steverao · 2025-09-26T06:57:42Z

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

        return DbSystemValues.CLICKHOUSE;
+      case "oceanbase": // Oceanbase
+        return DbSystemValues.OCEANBASE;
+      case "polardb": // polarDB


Suggested change

case "polardb": // polarDB

case "polardb": // PolarDB

steverao · 2025-09-26T06:58:31Z

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

+        return DbSystemValues.OCEANBASE;
+      case "polardb": // polarDB
+        return DbSystemValues.POLARDB;
+      case "lindorm": // lindorm


Suggested change

case "lindorm": // lindorm

case "lindorm": // Lindorm

steverao · 2025-09-26T06:59:03Z

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

+  },
+  /**
+   * <a
+   * href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints?spm=a2c63.p38356.help-menu-172543.d_2_0_1.7a1e41feMntzyJ">Driver


Suggested change

* href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints?spm=a2c63.p38356.help-menu-172543.d_2_0_1.7a1e41feMntzyJ">Driver

* href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints">Driver

deleted

did you forget to actually delete the url parameters?

steverao · 2025-09-26T07:29:02Z

...rc/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java

+
+  private static Stream<Arguments> oceanbaseArguments() {
+    return args(
+        // https://docs.aws.amazon.com/secretsmanager/latest/userguide/retrieving-secrets_jdbc.html


It it correct url?

steverao · 2025-09-26T07:29:25Z

...rc/test/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParserTest.java

+
+  private static Stream<Arguments> lindormArguments() {
+    return args(
+        // https://docs.aws.amazon.com/secretsmanager/latest/userguide/retrieving-secrets_jdbc.html


Same question with above

Change-Id: I39d2ce579c60d5afa2e792f3296eef5d0b495443

…r' into feature/additonal-jdbc-url-parser Change-Id: I5b6ee06da60fc32dc1edece63948d228c95f710b

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

laurit · 2025-09-29T12:08:07Z

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

+        if (subtype.equals(DbSystemValues.ORACLE)) {
+          builder.system(DbSystemValues.ORACLE);
+        }


initially I though that it is weird to have subtype and system set to the same value but DATADIRECT url handling does the same

Yes, I've referred to DATADIRECT

laurit · 2025-09-29T12:22:56Z

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java

      return GENERIC_URL_LIKE.doParse(clickhouseUrl, builder);
    }
+  },
+  /** jdbc:oceanbase://host:port/dbname jdbc:oceanbase:oracle://host:port/dbname */


perhaps change the comment to

/** * Sample urls: * * <ul> * <li>jdbc:oceanbase://host:port/dbname * <li>jdbc:oceanbase:oracle://host:port/dbname * </ul> */

otelbot-java-instrumentation · 2025-10-09T08:29:12Z

🔧 The result from spotlessApply was committed to the PR branch.

Change-Id: Ic7a1bdab51668642fb2c3e4b775ce30f4e1a841c

…r' into feature/additonal-jdbc-url-parser Change-Id: I6205bbedb81199c2bded7b78112389ca0b935636

otelbot-java-instrumentation · 2025-10-09T09:47:10Z

🔧 The result from spotlessApply was committed to the PR branch.

otelbot · 2025-10-09T17:14:38Z

Thank you for your contribution @pepeshore! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

pepeshore and others added 3 commits September 18, 2025 15:27

feat: support parse oceanbase、lindorm、polardb、opentracing connection url

8282947

Change-Id: Ia3b5f6b74b40763c4df7fa0185223575a2c1b068

Merge branch 'open-telemetry:main' into feature/additonal-jdbc-url-pa…

d0acc07

…rser

delete test main method

4251ef4

pepeshore requested a review from a team as a code owner September 25, 2025 08:01

github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Sep 25, 2025

./gradlew spotlessApply

8d79717

steverao changed the title ~~feat: OceanBase、PolarDB、Lindorm JDBC URL Parse Support （#14702）~~ Add JDBC URL parsing support for OceanBase, PolarDB and Lindorm Sep 26, 2025

steverao reviewed Sep 26, 2025

View reviewed changes

pepeshore added 2 commits September 28, 2025 20:27

fix：fix some code comments

a4a325f

Change-Id: I39d2ce579c60d5afa2e792f3296eef5d0b495443

Merge remote-tracking branch 'origin/feature/additonal-jdbc-url-parse…

28c2324

…r' into feature/additonal-jdbc-url-parser Change-Id: I5b6ee06da60fc32dc1edece63948d228c95f710b

laurit reviewed Sep 29, 2025

View reviewed changes

...ry/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/JdbcConnectionUrlParser.java Show resolved Hide resolved

laurit reviewed Sep 29, 2025

View reviewed changes

pepeshore and others added 2 commits October 9, 2025 16:22

Optimized the comments for OceanBase url parser

e5d0f3c

./gradlew spotlessApply

ae6a467

pepeshore and others added 3 commits October 9, 2025 17:20

delete url parameter

660f26b

Change-Id: Ic7a1bdab51668642fb2c3e4b775ce30f4e1a841c

Merge remote-tracking branch 'origin/feature/additonal-jdbc-url-parse…

548e0df

…r' into feature/additonal-jdbc-url-parser Change-Id: I6205bbedb81199c2bded7b78112389ca0b935636

./gradlew spotlessApply

73286f8

laurit added 2 commits October 9, 2025 14:19

Merge branch 'main' into feature/additonal-jdbc-url-parser

87105b6

review

92a0e4c

laurit added this to the v2.21.0 milestone Oct 9, 2025

laurit approved these changes Oct 9, 2025

View reviewed changes

trask merged commit a8b77e1 into open-telemetry:main Oct 9, 2025
83 checks passed

	* href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints?spm=a2c63.p38356.help-menu-172543.d_2_0_1.7a1e41feMntzyJ">Driver
	* href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints">Driver

Add JDBC URL parsing support for OceanBase, PolarDB and Lindorm #14790

Add JDBC URL parsing support for OceanBase, PolarDB and Lindorm #14790

Uh oh!

Conversation

pepeshore commented Sep 25, 2025 • edited by steverao Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

otelbot-java-instrumentation bot commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otelbot-java-instrumentation bot commented Oct 9, 2025

Uh oh!

otelbot-java-instrumentation bot commented Oct 9, 2025

Uh oh!

Uh oh!

otelbot bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pepeshore commented Sep 25, 2025 •

edited by steverao

Loading

linux-foundation-easycla bot commented Sep 25, 2025 •

edited

Loading