Skip to content

Replace EndBug/add-and-commit github action in benchmarks #14799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trask merged 2 commits into from
Sep 25, 2025
Merged

Replace EndBug/add-and-commit github action in benchmarks #14799

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55cbc26
update benchmarks script
jaydeluca Sep 25, 2025
6da541a
remove token
jaydeluca Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions .github/workflows/overhead-benchmark-daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,23 @@ jobs:
- name: Copy results back to gh-pages branch
run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ && rm -rf benchmark-overhead/results

- name: Commit updated results
uses: EndBug/add-and-commit@a94899bca583c204427a224a7af87c02f9b325d5 # v9.1.4
- name: Use CLA approved bot
run: .github/scripts/use-cla-approved-bot.sh

- uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
id: otelbot-token
with:
add: "benchmark-overhead/results"
cwd: "./gh-pages"
branch: "gh-pages"
message: "update test result data"
author_name: otelbot
author_email: [email protected]
committer_name: otelbot
committer_email: [email protected]
app-id: ${{ vars.OTELBOT_APP_ID }}
private-key: ${{ secrets.OTELBOT_PRIVATE_KEY }}

- name: Commit updated results
env:
GH_TOKEN: ${{ steps.otelbot-token.outputs.token }}
Copy link
Member

@trask trask Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that no special token is needed here since it was working before

Suggested change
env:
GH_TOKEN: ${{ steps.otelbot-token.outputs.token }}

working-directory: ./gh-pages
run: |
git add benchmark-overhead/results
git commit -m "update test result data"
git push

workflow-notification:
permissions:
Expand Down
Loading