JAXWS metadata #14864
JAXWS metadata #14864
Conversation
docs/instrumentation-list.yaml
Outdated
| library_link: https://github.com/jakartaee/jax-ws-api | ||
| features: | ||
| - CONTROLLER_SPANS | ||
| - CONTEXT_PROPAGATION |
There was a problem hiding this comment.
does it really do context propagation?
There was a problem hiding this comment.
am i misinterpreting this?
There was a problem hiding this comment.
am i misinterpreting this?
Context propagation usually means passing the context through header between applications or inter thread context propagation where context is somehow passed from one thread to another. Perhaps storing the context and passing it to a callback could also be considered context propagation. The linked code just creates a span and activates the context that contains that span. I don't think that qualifies as context propagation. I think we need to clarify what CONTEXT_PROPAGATION means.
There was a problem hiding this comment.
thanks, this was a misunderstanding on my part. I've updated the documentation to better match the more narrow definition and removed that label from these instrumentations.
There was a problem hiding this comment.
thinking more about this, i wonder if the more useful bit would be further distinguishing this in the sense of context propagation injectors (clients, producers) or extractors (servers, consumers) ?
…ve experimental feature descriptor entirely
docs/instrumentation-list.yaml
Outdated
| - javax.xml.ws:jaxws-api:[2.0,] | ||
| configurations: | ||
| - name: otel.instrumentation.common.experimental.controller-telemetry.enabled | ||
| description: Enables the creation of experimental controller (INTERNAL) spans. |
There was a problem hiding this comment.
I'm not sure about the (INTERNAL). Should we expect our users to understand the different span kinds, or care about them? When we use server span then it sort of makes sense even if you don't know that we have spans of different kinds.
neither do I, and I haven't been able to reproduce it locally |
|
looks like it's happening elsewhere too: #14929 |
|
@zeitlinger could you help with the link check failure |
3 participants
Part of #13468
Related to #14096
Along with the metadata, I also moved the
instrumentation/jaxws/jaxws-2.0-axis2-1.6-testingmodule intoinstrumentation/jaxws/jaxws-2.0-axis2-1.6/testingbecause it didn't seem necessary for them to be separate modules (there's only 1 module using the-testingmodule , and there were no tests in thejaxws-2.0-axis2-1.6module.)