Skip to content

Update metric descriptions to match semantic conventions and add automated verification #14874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Update metric descriptions to match semantic conventions and add automated verification #14874

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69b33b6
Initial plan
Copilot Oct 3, 2025
2a7c731
Update RPC metric descriptions to match semantic conventions
Copilot Oct 3, 2025
6ce81c3
Fix GenAI and DB pool metric descriptions to match semantic conventions
Copilot Oct 3, 2025
f191807
Add metric description assertions to RPC tests
Copilot Oct 3, 2025
366bf42
Update GenAI test descriptions to match semantic conventions
Copilot Oct 3, 2025
965881e
Fix DB connection pool test assertion for state attribute description
Copilot Oct 3, 2025
180482c
Add daily workflow to verify metric descriptions match semantic conve…
Copilot Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...va/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbConnectionPoolMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public ObservableLongMeasurement connections() {
.upDownCounterBuilder(metricName)
.setUnit(emitStableDatabaseSemconv() ? "{connection}" : "{connections}")
.setDescription(
"The number of connections that are currently in state described by the state attribute.")
"The number of connections that are currently in state described by the `state` attribute.")
.buildObserver();
}

Expand Down
2 changes: 1 addition & 1 deletion ...java/io/opentelemetry/instrumentation/api/incubator/semconv/genai/GenAiClientMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private GenAiClientMetrics(Meter meter) {
.histogramBuilder("gen_ai.client.token.usage")
.ofLongs()
.setUnit("{token}")
.setDescription("Measures number of input and output tokens used.")
.setDescription("Number of input and output tokens used.")
.setExplicitBucketBoundariesAdvice(GenAiMetricsAdvice.CLIENT_TOKEN_USAGE_BUCKETS);
GenAiMetricsAdvice.applyClientTokenUsageAdvice(tokenUsageBuilder);
this.tokenUsage = tokenUsageBuilder.build();
Expand Down
2 changes: 1 addition & 1 deletion ...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcClientMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private RpcClientMetrics(Meter meter) {
DoubleHistogramBuilder durationBuilder =
meter
.histogramBuilder("rpc.client.duration")
.setDescription("The duration of an outbound RPC invocation.")
.setDescription("Measures the duration of outbound RPC.")
.setUnit("ms");
RpcMetricsAdvice.applyClientDurationAdvice(durationBuilder);
clientDurationHistogram = durationBuilder.build();
Expand Down
2 changes: 1 addition & 1 deletion ...ain/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcServerMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private RpcServerMetrics(Meter meter) {
DoubleHistogramBuilder durationBuilder =
meter
.histogramBuilder("rpc.server.duration")
.setDescription("The duration of an inbound RPC invocation.")
.setDescription("Measures the duration of inbound RPC.")
.setUnit("ms");
RpcMetricsAdvice.applyServerDurationAdvice(durationBuilder);
serverDurationHistogram = durationBuilder.build();
Expand Down
2 changes: 2 additions & 0 deletions ...java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcClientMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ void collectsMetrics() {
assertThat(metric)
.hasName("rpc.client.duration")
.hasUnit("ms")
.hasDescription("Measures the duration of outbound RPC.")
.hasHistogramSatisfying(
histogram ->
histogram.hasPointsSatisfying(
Expand Down Expand Up @@ -112,6 +113,7 @@ void collectsMetrics() {
assertThat(metric)
.hasName("rpc.client.duration")
.hasUnit("ms")
.hasDescription("Measures the duration of outbound RPC.")
.hasHistogramSatisfying(
histogram ->
histogram.hasPointsSatisfying(
Expand Down
2 changes: 2 additions & 0 deletions ...java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcServerMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ void collectsMetrics() {
assertThat(metric)
.hasName("rpc.server.duration")
.hasUnit("ms")
.hasDescription("Measures the duration of inbound RPC.")
.hasHistogramSatisfying(
histogram ->
histogram.hasPointsSatisfying(
Expand Down Expand Up @@ -113,6 +114,7 @@ void collectsMetrics() {
assertThat(metric)
.hasName("rpc.server.duration")
.hasUnit("ms")
.hasDescription("Measures the duration of inbound RPC.")
.hasHistogramSatisfying(
histogram ->
histogram.hasPointsSatisfying(
Expand Down