Skip to content

Remove experimental flag requirement for spec'd AWS SDK attributes #14888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −9
Open

Remove experimental flag requirement for spec'd AWS SDK attributes #14888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffafd35
Initial plan
Copilot Oct 3, 2025
908f4ab
Remove experimental flag requirement for spec'd AWS attributes
Copilot Oct 3, 2025
41525db
Fix unused variable warning with @SuppressWarnings annotation
Copilot Oct 3, 2025
ef8a880
Remove unused captureExperimentalSpanAttributes parameter
Copilot Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AwsSdkTelemetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ public ExecutionInterceptor newExecutionInterceptor() {
dynamoDbInstrumenter,
bedrockRuntimeInstrumenter,
eventLogger,
captureExperimentalSpanAttributes,
messagingPropagator,
useXrayPropagator,
recordIndividualHttpError,
Expand Down
11 changes: 3 additions & 8 deletions ...va/io/opentelemetry/instrumentation/awssdk/v2_2/internal/TracingExecutionInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ public final class TracingExecutionInterceptor implements ExecutionInterceptor {
private final Instrumenter<ExecutionAttributes, Response> dynamoDbInstrumenter;
private final Instrumenter<ExecutionAttributes, Response> bedrockRuntimeInstrumenter;
private final Logger eventLogger;
private final boolean captureExperimentalSpanAttributes;

static final AttributeKey<String> HTTP_ERROR_MSG =
AttributeKey.stringKey("aws.http.error_message");
Expand Down Expand Up @@ -117,7 +116,6 @@ public TracingExecutionInterceptor(
Instrumenter<ExecutionAttributes, Response> dynamoDbInstrumenter,
Instrumenter<ExecutionAttributes, Response> bedrockRuntimeInstrumenter,
Logger eventLogger,
boolean captureExperimentalSpanAttributes,
TextMapPropagator messagingPropagator,
boolean useXrayPropagator,
boolean recordIndividualHttpError,
Expand All @@ -129,7 +127,6 @@ public TracingExecutionInterceptor(
this.dynamoDbInstrumenter = dynamoDbInstrumenter;
this.bedrockRuntimeInstrumenter = bedrockRuntimeInstrumenter;
this.eventLogger = eventLogger;
this.captureExperimentalSpanAttributes = captureExperimentalSpanAttributes;
this.messagingPropagator = messagingPropagator;
this.useXrayPropagator = useXrayPropagator;
this.recordIndividualHttpError = recordIndividualHttpError;
Expand Down Expand Up @@ -401,11 +398,9 @@ private void onSdkResponse(
BedrockRuntimeAccess.recordResponseEvents(
otelContext, eventLogger, executionAttributes, response, genAiCaptureMessageContent);
}
if (captureExperimentalSpanAttributes) {
AwsSdkRequest sdkRequest = executionAttributes.getAttribute(AWS_SDK_REQUEST_ATTRIBUTE);
if (sdkRequest != null) {
fieldMapper.mapToAttributes(response, sdkRequest, span);
}
AwsSdkRequest sdkRequest = executionAttributes.getAttribute(AWS_SDK_REQUEST_ATTRIBUTE);
if (sdkRequest != null) {
fieldMapper.mapToAttributes(response, sdkRequest, span);
}
}

Expand Down
Loading