Convert ReferenceMatcherTest to groovy #14905
Merged
+538
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Oct 10, 2025
muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcherTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 10, 2025
muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcherTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 10, 2025
| } | ||
|
|
||
| @ParameterizedTest | ||
| @CsvSource({ |
There was a problem hiding this comment.
did you consider using @MethodSource so you wouldn't need to decode the strings?
laurit
reviewed
Oct 10, 2025
| } | ||
|
|
||
| @ParameterizedTest | ||
| @CsvSource({ |
There was a problem hiding this comment.
did you consider using @MethodSource so you wouldn't need to decode the strings?
…/ReferenceMatcherTest.java Co-authored-by: Lauri Tulmin <[email protected]>
zeitlinger
force-pushed
the
convert-grooy-tests-reference
branch
from
9b6f726 to
f125132
Compare
laurit
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14803