Convert matcher tests to java #14911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
approved these changes
Oct 8, 2025
laurit
reviewed
Oct 8, 2025
Comment on lines
67
to
68
| assertThatCode(() -> extendsClass(named(Object.class.getName())).matches(type)) | ||
| .doesNotThrowAnyException(); |
There was a problem hiding this comment.
if it really threw an exception then the test would already failed the first time when you called it
There was a problem hiding this comment.
it was noExceptionThrown() before - but I can just make it a comment
laurit
reviewed
Oct 8, 2025
|
|
||
| @ParameterizedTest | ||
| @CsvSource({ | ||
| "io.opentelemetry.javaagent.tooling.bytebuddy.matcher.testclasses.A, io.opentelemetry.javaagent.tooling.bytebuddy.matcher.testclasses.B, false", |
There was a problem hiding this comment.
could consider dropping the package name from here and adding it inside the test method
There was a problem hiding this comment.
that makes it just harder to find usages in the IDE
laurit
reviewed
Oct 8, 2025
|
|
||
| import java.util.Iterator; | ||
|
|
||
| public class ThrowOnFirstElement implements Iterator<Object> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14803