convert cache provider test to java #14918
Merged
+180
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Oct 8, 2025
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/AgentCachingPoolStrategy.java
Show resolved
Hide resolved
laurit
reviewed
Oct 8, 2025
muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/CacheProviderTest.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 8, 2025
| assertThat(key1).hasSameHashCodeAs(key2); | ||
| assertThat(key1).isEqualTo(key2); | ||
| // ensures that loader isn't collected | ||
| assertThat(loader).isNotNull(); |
There was a problem hiding this comment.
loader can not be null at this point so, as it is, this assertion doesn't really make sense
There was a problem hiding this comment.
I think I get it now. The intention is to use the loader at the end of the method to ensure that it isn't collected before.
laurit
reviewed
Oct 8, 2025
muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/CacheProviderTest.java
Outdated
Show resolved
Hide resolved
|
@laurit please check again |
laurit
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14803