Skip to content

Allow excluding Logback MDC attributes from being copied #14926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow excluding Logback MDC attributes from being copied #14926

wants to merge 3 commits into from
+38 −8

Conversation

cfredri4
Copy link

@cfredri4 cfredri4 commented Oct 8, 2025

Closes #14925

@cfredri4
Add excluding Logback MDC attributes
54027b2 
This change adds a setting to the Logback appender to exclude MDC attributes when all attributes are being copied.
@cfredri4 cfredri4 requested a review from a team as a code owner October 8, 2025 20:13
@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@trask
Copy link
Member

trask commented Oct 8, 2025

my initial thought is that this should be the default behavior (for both javaagent and library instrumentation), and you should have to opt in somehow if you want the duplication (e.g. #14897 / #14904)

@cfredri4
Copy link
Author

cfredri4 commented Oct 8, 2025

@trask additional context: I use Micrometer for tracing which adds the MDC values traceId, spanId (i.e. different from trace_id and span_id exported by the appender).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow excluding Logback MDC attributes from being copied
2 participants
@cfredri4 @trask