Add support for Apache Elasticjob #14933

steverao · 2025-10-09T07:15:41Z

Resolved #10967

docs/supported-libraries.md

...etry/javaagent/instrumentation/apacheelasticjob/v3_0/DataflowJobExecutorInstrumentation.java

...metry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobExecutorInstrumentation.java

.../java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobHelper.java

...a/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/EmbedZookeeperServer.java

...st/java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobTest.java

…error handling and OS compatibility

otelbot-java-instrumentation · 2025-10-14T12:46:53Z

🔧 The result from spotlessApply was committed to the PR branch.

.../java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobHelper.java

...st/java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobTest.java

…ssertions

otelbot-java-instrumentation · 2025-10-15T08:48:41Z

🔧 The result from spotlessApply was committed to the PR branch.

...avaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobExperimentalAttributeExtractor.java

laurit

For me all the tests fail with

org.apache.shardingsphere.elasticjob.infra.env.HostException: ip is null
	at org.apache.shardingsphere.elasticjob.infra.env.IpUtils.getIp(IpUtils.java:68)
	at org.apache.shardingsphere.elasticjob.infra.handler.sharding.JobInstance.<init>(JobInstance.java:44)
	at org.apache.shardingsphere.elasticjob.lite.internal.schedule.JobScheduler.registerStartUpInfo(JobScheduler.java:176)
	at org.apache.shardingsphere.elasticjob.lite.internal.schedule.JobScheduler.createJobScheduleController(JobScheduler.java:140)
	at org.apache.shardingsphere.elasticjob.lite.internal.schedule.JobScheduler.<init>(JobScheduler.java:90)
	at org.apache.shardingsphere.elasticjob.lite.api.bootstrap.impl.ScheduleJobBootstrap.<init>(ScheduleJobBootstrap.java:36)
	at io.opentelemetry.javaagent.instrumentation.apacheelasticjob.v3_0.ElasticJobTest.testSimpleJob(ElasticJobTest.java:137)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

...ain/java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/JobTypeHelper.java

...avaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobExperimentalAttributeExtractor.java

...etry/javaagent/instrumentation/apacheelasticjob/v3_0/DataflowJobExecutorInstrumentation.java

...elemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobCodeAttributesGetter.java

...st/java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobTest.java

...a/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/EmbedZookeeperServer.java

instrumentation/apache-elasticjob-3.0/javaagent/build.gradle.kts

steverao · 2025-11-11T13:10:08Z

For me all the tests fail with

org.apache.shardingsphere.elasticjob.infra.env.HostException: ip is null
	at org.apache.shardingsphere.elasticjob.infra.env.IpUtils.getIp(IpUtils.java:68)
	at org.apache.shardingsphere.elasticjob.infra.handler.sharding.JobInstance.<init>(JobInstance.java:44)
	at org.apache.shardingsphere.elasticjob.lite.internal.schedule.JobScheduler.registerStartUpInfo(JobScheduler.java:176)
	at org.apache.shardingsphere.elasticjob.lite.internal.schedule.JobScheduler.createJobScheduleController(JobScheduler.java:140)
	at org.apache.shardingsphere.elasticjob.lite.internal.schedule.JobScheduler.<init>(JobScheduler.java:90)
	at org.apache.shardingsphere.elasticjob.lite.api.bootstrap.impl.ScheduleJobBootstrap.<init>(ScheduleJobBootstrap.java:36)
	at io.opentelemetry.javaagent.instrumentation.apacheelasticjob.v3_0.ElasticJobTest.testSimpleJob(ElasticJobTest.java:137)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

It's fine for me, It looks like an issue from elasticJob client in some special network environments.
https://github.com/apache/shardingsphere-elasticjob/issues?q=is%3Aissue%20org.apache.shardingsphere.elasticjob.infra.env.HostException%3A%20ip%20is%20null

...st/java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobTest.java

...metry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobExecutorInstrumentation.java

steverao added 4 commits October 9, 2025 14:21

feat: add support for elasticJob

456a8b4

feat: add support for elasticjob

011d725

Improve code formatting

c501345

fix: remove redundant newline in settings.gradle.kts

36ded9c

steverao requested a review from a team as a code owner October 9, 2025 07:15

steverao and others added 2 commits October 9, 2025 16:37

Fix CI failings

a3efe69

Merge branch 'main' into elasticjob

0c4aabe

laurit reviewed Oct 13, 2025

View reviewed changes

steverao and others added 3 commits October 14, 2025 20:37

Address review comments

b751d37

refactor: improve ElasticJobTest and EmbedZookeeperServer for better …

29f5b47

…error handling and OS compatibility

./gradlew spotlessApply

901516b

jaydeluca reviewed Oct 15, 2025

View reviewed changes

steverao and others added 2 commits October 15, 2025 16:41

refactor: streamline ElasticJobTest structure and enhance attribute a…

14dc3ce

…ssertions

./gradlew spotlessApply

9b0ead0

steverao added 2 commits October 31, 2025 10:09

refactor: rename ElasticJobExecutorAdvice to ProcessAdvice

d712d3c

Optimize code

b4604cf

steverao requested review from jaydeluca, laurit and trask November 10, 2025 08:14

jaydeluca reviewed Nov 10, 2025

View reviewed changes

...avaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobExperimentalAttributeExtractor.java Outdated Show resolved Hide resolved

Address review comment

de49063

laurit reviewed Nov 11, 2025

View reviewed changes

Address review comment

7c1dd52

steverao and others added 3 commits November 13, 2025 09:45

Merge branch 'main' into elasticjob

08804f7

Merge branch 'main' into elasticjob

149ef02

review

150a7cc

laurit reviewed Nov 19, 2025

View reviewed changes

...st/java/io/opentelemetry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobTest.java Outdated Show resolved Hide resolved

review

6163e73

laurit reviewed Nov 19, 2025

View reviewed changes

...metry/javaagent/instrumentation/apacheelasticjob/v3_0/ElasticJobExecutorInstrumentation.java Outdated Show resolved Hide resolved

steverao and others added 3 commits November 20, 2025 16:29

Address review comments

4303a78

Address review comments

32d463b

review

4e306cf

laurit approved these changes Nov 20, 2025

View reviewed changes

laurit added this to the v2.23.0 milestone Nov 20, 2025

trask merged commit 8923112 into open-telemetry:main Nov 20, 2025
88 checks passed

Add support for Apache Elasticjob #14933

Add support for Apache Elasticjob #14933

Uh oh!

Conversation

steverao commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

otelbot-java-instrumentation bot commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

otelbot-java-instrumentation bot commented Oct 15, 2025

Uh oh!

Uh oh!

laurit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steverao commented Nov 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants