Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/contributing/documenting-instrumentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Some notes when writing descriptions:
"This instrumentation **enables** HTTP server spans and HTTP server metrics for the ActiveJ" instead
of something like "This instrumentation **provides** HTTP server spans and HTTP server metrics for the ActiveJ".
* Explicitly state whether the instrumentation generates new telemetry (spans, metrics, logs).
* If it doesn't generate new telemetry, clearly explain what it's purpose is, for example whether it
* If it doesn't generate new telemetry, clearly explain what its purpose is, for example whether it
augments or enriches existing telemetry produced by other instrumentations (e.g., by adding
attributes or ensuring context propagation).
* When describing the functionality of the instrumentation and the telemetry, specify using
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* This test creates the specified number of traces with three spans: 1) Outer (root) span 2) Middle
* span, child of outer, created in success handler of the chain subscribed to in the context of the
* outer span (with some delay and map thrown in for good measure) 3) Inner span, child of middle,
* created in the success handler of a new chain started and subscribed to in the the middle span
* created in the success handler of a new chain started and subscribed to in the middle span
*
* <p>The varying delays between the stages where each span is created should guarantee that
* scheduler threads handling various stages of the chain will have to alternate between contexts
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* This test creates the specified number of traces with three spans: 1) Outer (root) span 2) Middle
* span, child of outer, created in success handler of the chain subscribed to in the context of the
* outer span (with some delay and map thrown in for good measure) 3) Inner span, child of middle,
* created in the success handler of a new chain started and subscribed to in the the middle span
* created in the success handler of a new chain started and subscribed to in the middle span
*
* <p>The varying delays between the stages where each span is created should guarantee that
* scheduler threads handling various stages of the chain will have to alternate between contexts
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ public void visitCode() {
Type[] argumentTypes = ga.getArgumentTypes();

if (isEnterAdvice) {
// we have changed the type fo method arguments annotated with @Advice.Local to Object
// we have changed the type of method arguments annotated with @Advice.Local to Object
// here we'll load the argument, cast it to its actual type, and store it back
for (AdviceLocal adviceLocal : adviceLocals) {
ga.loadArg(adviceLocal.adviceIndex);
Expand Down
Loading