-
Couldn't load subscription status.
- Fork 1k
Feat/aerospike integration #14988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/aerospike integration #14988
Conversation
|
|
❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18522835911. |
…/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v3_9/aerospike/VertxAerospikeClientTest.java
|
❌ The result from generateLicenseReport could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18523062193. |
|
❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18523084738. |
Changed aerospike integration version to 4.0.0
|
❌ The result from generateLicenseReport could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18528880540. |
|
❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18528898232. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rohitpandit0007 , this PR is too large for us to properly being able to review it.
I would suggest to split changes in smaller and more manageable parts:
- adding
instrumentation/vertx-aerospike-client-3.9in this PR - other necesary changes in separate PRs, for example all the other changes in
instrumentation/vertx-*
I'm not familiar at all with aerospike and how it integrates into the vertx ecosystem, but with such large code changes it's better to split into multiple parts, ideally described into a single issue/sub-issues for more clarity on the progress and the overall motivation of this change.
No description provided.