Skip to content

Conversation

@rohitpandit0007
Copy link

No description provided.

@rohitpandit0007 rohitpandit0007 requested a review from a team as a code owner October 15, 2025 08:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 15, 2025

CLA Not Signed

@otelbot-java-instrumentation
Copy link
Contributor

❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18522835911.

…/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v3_9/aerospike/VertxAerospikeClientTest.java
@otelbot-java-instrumentation
Copy link
Contributor

❌ The result from generateLicenseReport could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18523062193.

@otelbot-java-instrumentation
Copy link
Contributor

❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18523084738.

Changed aerospike integration version to 4.0.0
@otelbot-java-instrumentation
Copy link
Contributor

❌ The result from generateLicenseReport could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18528880540.

@otelbot-java-instrumentation
Copy link
Contributor

❌ The result from spotlessApply could not be committed to the PR branch, see logs: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/18528898232.

Copy link
Contributor

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rohitpandit0007 , this PR is too large for us to properly being able to review it.

I would suggest to split changes in smaller and more manageable parts:

  • adding instrumentation/vertx-aerospike-client-3.9 in this PR
  • other necesary changes in separate PRs, for example all the other changes in instrumentation/vertx-*

I'm not familiar at all with aerospike and how it integrates into the vertx ecosystem, but with such large code changes it's better to split into multiple parts, ideally described into a single issue/sub-issues for more clarity on the progress and the overall motivation of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants