Bring in newer upstream Couchbase instrumentation to fix span kind #14995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
🔧 The result from spotlessApply was committed to the PR branch. |
trask
force-pushed
the
couchbase-span-kind-test
branch
from
a95c636 to
917f96f
Compare
trask
force-pushed
the
couchbase-span-kind-test
branch
from
917f96f to
2534bda
Compare
jaydeluca
reviewed
Oct 21, 2025
|
|
||
| testImplementation(project(":instrumentation:couchbase:couchbase-common:testing")) | ||
|
|
||
| // TODO testInstrumentation(project(":instrumentation:couchbase:couchbase-2.6:javaagent")) |
There was a problem hiding this comment.
what is needed to be done for all of these TODOs in each gradle file?
There was a problem hiding this comment.
need to find a class that exists in one of the versions that doesn't exist so we can scope the version better via muzzle
jaydeluca
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14982